Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Modrinth.Net/Endpoints/Team/ITeamEndpoint.cs
Original file line number Diff line number Diff line change
Expand Up @@ -93,5 +93,5 @@ public interface ITeamEndpoint
/// <returns></returns>
/// <exception cref="ModrinthApiException"> Thrown when the API returns an error or the request fails </exception>
Task ModifyMemberAsync(string teamId, string userId, string role, Permissions permissions, int payoutsSplit,
int ordering, CancellationToken cancellationToken = default);
long ordering, CancellationToken cancellationToken = default);
}
2 changes: 1 addition & 1 deletion src/Modrinth.Net/Endpoints/Team/TeamEndpoint.cs
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ public async Task TransferOwnershipAsync(string teamId, string userId,
/// <inheritdoc />
public async Task ModifyMemberAsync(string teamId, string userId, string role, Permissions permissions,
int payoutsSplit,
int ordering, CancellationToken cancellationToken = default)
long ordering, CancellationToken cancellationToken = default)
{
using var reqMsg = new HttpRequestMessage();
reqMsg.Method = HttpMethod.Patch;
Expand Down
2 changes: 1 addition & 1 deletion src/Modrinth.Net/Models/TeamMember.cs
Original file line number Diff line number Diff line change
Expand Up @@ -50,5 +50,5 @@ public class TeamMember
/// <summary>
/// The order of the team member.
/// </summary>
public int? Ordering { get; set; }
public long? Ordering { get; set; }
}
26 changes: 26 additions & 0 deletions test/Modrinth.Net.Test/RequesterTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -215,4 +215,30 @@ public async Task GetJsonAsync_GalleryOrderingHugeInt64_DeserializesSuccessfully

Assert.That(galleries[0].Ordering, Is.EqualTo(expectedOrdering));
}

[Test]
public async Task GetJsonAsync_TeamMemberOrderingAboveInt32Max_DeserializesSuccessfully()
{
const long expectedOrdering = 6844313514;
var json =
"[{\"team_id\":\"team_1\",\"user\":{\"username\":\"user\",\"name\":\"User\",\"id\":\"u1\",\"github_id\":null,\"avatar_url\":\"https://example.com/avatar.png\",\"bio\":\"\",\"created\":\"2026-01-01T00:00:00Z\",\"role\":\"developer\"},\"role\":\"Owner\",\"permissions\":null,\"accepted\":true,\"payouts_split\":null,\"ordering\":" +
expectedOrdering + "}]";

var handler = new DelegateMessageHandler((_, _) =>
Task.FromResult(new HttpResponseMessage(HttpStatusCode.OK)
{
Content = new StringContent(json, Encoding.UTF8, "application/json")
}));

using var requester = CreateRequester(handler);
var request = new HttpRequestMessage(HttpMethod.Get, "http://test.com");

var teamMembers = await requester.GetJsonAsync<TeamMember[]>(request);

using (Assert.EnterMultipleScope())
{
Assert.That(teamMembers, Has.Length.EqualTo(1));
Assert.That(teamMembers[0].Ordering, Is.EqualTo(expectedOrdering));
}
}
}
Loading