fix(mobile): keep comment authors and threads when the phone rewrites a sidecar - #61
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Between the 1.1.16 pin and a3e638fc, desktop
vault.tsreplaced its private comment normalizer with the shared@shared/note-comments, which keeps the app core 2.46authorandparentIdfields. The shell'sMobileVault.writeNoteCommentsstill rebuilt each record from a fixed field list, and app-core hands over the whole list on every comment action, so one reply, resolve, or delete on the phone flattened every thread and dropped every name the desktop or an assistant had written into the sidecar.src/bridge/vault-fs.tsnow reads and writes the sidecar through the shared normalizer, as desktop does. Same fix as iPhone 1.9.8.Also points the 1.1.18 pack at iPhone 1.9.8 (build 19): the iOS release was renumbered from 1.9.9, since the pin-only 1.9.8 never shipped.
Verified:
npm run typecheckclean at the pin,npm run buildclean,npm test50/50.MobileVaultcannot run undernode --test, and the fix was not re-run on the AVD.