fix: keep Excalidraw's font pack out of the Android bundle (versionCode 24) - #70
Merged
Merged
Conversation
The core's Vite helper copies Excalidraw's complete font pack into the build unless told otherwise: 234 files and about 13 MB, 12 MB of which are the 209 Xiaolai CJK handwriting subsets. 1.1.20 shipped without them and drawings resolved their fonts as they always have, so the first packaged build grew the Play download from 30.6 MB to 43.8 MB for no user-visible gain. Pass excalidraw: false to restore the previous asset set (47 web fonts, no excalidraw-assets directory).
Version code 23 was uploaded to Play's bundle library before the font-pack regression was caught, so the corrected 1.1.21 bundle needs a new code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The first packaged 1.1.21 build (#69, versionCode 23) grew the Play download from 30.6 MB to 43.8 MB. All of the growth is Excalidraw's font pack, which the core's Vite helper copies into the bundle unless told otherwise: 234 files, about 13 MB, 12 MB of it the 209 Xiaolai CJK handwriting subsets. 1.1.20 shipped without them and drawings resolved fonts as they always have.
excalidraw: falsetozenNotesAssetsin vite.config.ts. The built asset set is back to 47 web fonts and noexcalidraw-assetsdirectory; the boot-path closure is unchanged (1.58 MB).Validation
npm run boundaries:check,npm test(149),npm run typecheck,npm run build.