Refactor(ios): consume the shared editor through public packages - #23
Merged
adibhanna merged 2 commits intoSep 16, 2026
Merged
Conversation
Replace the cloned desktop source and private renderer/store imports with immutable core, bridge-contract, and shared-domain packages. iOS retains ownership of native files, Cloud/iCloud behavior, keyboard handling, and gestures while public core APIs coordinate editor and workspace actions. - Reserve native vault moves across save, move, reopen, and rollback; invalidate stale attachment/gesture contexts. - Initialize native typing and editor geometry through public host APIs. - Add package-boundary checks and a disposable native runtime fixture. - Align pod deployment targets with the app's existing iOS 15 minimum for the current Xcode toolchain. This PR is stacked on [#22](#22), `fix/cloud-live-regressions`. Its Cloud fixes are prerequisites, not duplicated changes. The unrelated local 1.9.10/build 21 Xcode version bump is excluded.
This was referenced Sep 16, 2026
Open
The production audit used to run inside the desktop source checkout, whose root manifest overrides the nested nanoid and mermaid parser versions that Excalidraw pulls in. Installing the core as a package moved the audit into this repository, where no overrides existed, so the same dependency tree failed on high advisories against nanoid 3.3.3, nanoid 4.0.2, and lodash-es 4.17.21. Add the same overrides. npm keeps already-nested lockfile entries even when overrides change, so the stale nested entries were removed and the tree re-resolved: 21 packages drop out, the resolution matches the desktop, and the audit reports nothing. The lockfile is stable on a second resolve. The same change on the local tree with the newer core candidate passes the boundary check, typecheck, unit tests, and the production build.
adibhanna
marked this pull request as ready for review
September 16, 2026 20:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the cloned desktop source and private renderer/store imports with immutable core, bridge-contract, and shared-domain packages. iOS retains ownership of native files, Cloud/iCloud behavior, keyboard handling, and gestures while public core APIs coordinate editor and workspace actions.
This PR is stacked on #22,
fix/cloud-live-regressions. Its Cloud fixes are prerequisites, not duplicated changes. The unrelated local 1.9.10/build 21 Xcode version bump is excluded.Validation
Draft dependencies
The vendored package set includes the v2.50.4 fixes and depends on the main ZenNotes public-package migration. Replace the validated dirty-source archives with reviewed clean artifacts before release. Real iCloud entitlements and account-backed Cloud acceptance remain staging gates. No application release is included.
Related boundary PRs