Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Safe simplification refactor for the Forge-only codebase.
This removes obsolete Connect-specific branches and collapses small local patterns that were adding code without changing behavior. The source diff is intentionally line-reducing:
15source files changed with51insertions and356deletions before adding the report.What Changed
/attachmentPages Function and its route allowlist entry.window.AP/postMessage close fallback from AI Aide and now uses Forge bridgeview.submit().xdm_eclient-domain extraction with Forge contextsiteUrl/extension.location.DocumentList.getToken(), and obsolete Connect-era tests/setup.docs/safe-simplification-refactor-2026-05-03.mdwith rationale, exact changes, verification, and independent revert guidance.Why
Production is Forge-only, with Connect retained only for manifest migration compatibility and install/uninstall lifecycle handling. Keeping Connect branches in frontend/runtime code makes the codebase harder to read and creates dead paths that cannot work in Forge.
Validation
pnpm vitest --run src/model/ContentProvider/CompositeContentProvider.spec.ts src/model/ContentProvider/ContentPropertyStorageProvider.spec.ts src/utils/ContextParameters/ContextParameters.spec.ts src/utils/isEmbedMode.spec.ts tests/unit/connect-window-ap.spec.tsvolta run --node 22.12.0 --pnpm 10.33.2 pnpm build:liteNote:
vue-tsc --noEmitis blocked by the existingvue-tsc@1.8.27/ TypeScript compatibility error before project source checking.