Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Project is pure Forge across all variants (lite/full/diagramly), so the
full-forgelabel — a leftover from the Connect→Forge migration — is redundant. This cleans up dead code and stale docs across the full variant pipeline.tests/e2e-tests/config/apps.ts— removed dead Connect-erazenuml-full@stgprofile (pointed atzenuml-stg.atlassian.net); renamedzenuml-full-forge@stg→zenuml-full@stg. Localpnpm test:full:stgnow correctly hits the live Forge full app onfull-stg.atlassian.net..github/workflows/build-test-deploy.yml—E2E: Fullnow usesapp: zenuml-full@stg..github/workflows/staging-deploy.yml— dropped deadfull-forgeternary; install-step condition flipped fromfull-forge→full. Behavior change: thestaging-fulljob will now runforge install --upgradeonfull-stg.atlassian.netafter each deploy. Previously this never fired (no caller passedfull-forge), so the staging Full app silently stayed pinned to whatever was last installed manually..claude/skills/{validate-branch,ship-branch,land-pr,babysit-pr}/SKILL.md— "4 variants" → "3 variants (lite, full, diagramly)".operations/full-forge-app.md→operations/full-app.md; title updated.full-forge-pipeline.md(described a dual Connect+Forge pipeline that no longer exists).CHANGELOG.mdleft as-is (historical record of the actual release label at that date).Affects all variants in CI plumbing, but the runtime behavior change is full only.
Test plan
pnpm vitest run --dir src→ 160/160 passedpython3 -c "import yaml; yaml.safe_load(...)"on both touched workflows → validgrep -rn "full-forge"excluding CHANGELOG → no matchesstaging-fullrun on main confirm the new install-upgrade step succeeds (continue-on-error, but should be green)