feat(viewer): redesign GenericViewer to V8 chrome-less surface#31
Draft
feat(viewer): redesign GenericViewer to V8 chrome-less surface#31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reimplements
GenericViewer.vueas the V8 chrome-less surface from the ZenUML for Confluence design system. Affects all variants (lite, full, diagramly).data-app)UpgradePromptmodal triggered by other surfaces. Revisit only as an explicit experiment with success metrics.EMBEDchip on the top-left edgeCopy linkaction — resolves the parent page URL viarequestConfluence(/wiki/api/v2/pages/{id}). Lazy-imported so the standalone preview harness still bootsscreen-capture-contentclass (used byAttachment.ts+ExportModal),wide/hideHeaderprops,EventBusedit/fullscreenevents,showEditpermission gating, all tracking eventsTest plan
pnpm test:unit src/components/Viewer/GenericViewer.spec.ts— 10/10 pass (rewrote spec for the V8 surface)pnpm build:litesucceedsviewer-preview.html?sandbox=seq-view— frame renders, hover reveals top + bottom edges, Edit click fires EventBusedit, resting hint shows when not hovering, orange Lite product-bar visible, dot-pattern canvas visibledata-app🤖 Generated with Claude Code