Repository navigation
[codex] Prepare 0.7.0 bugfix release - #18
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #18 +/- ##
==========================================
+ Coverage 66.39% 66.70% +0.31%
==========================================
Files 135 135
Lines 5008 5010 +2
Branches 754 635 -119
==========================================
+ Hits 3325 3342 +17
- Misses 1425 1430 +5
+ Partials 258 238 -20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b64234bca5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| server = self._start_mock_server( | ||
| BitcoinMainUnit.BlockcypherTXHistoryResponseManager, | ||
| port, | ||
| ) |
There was a problem hiding this comment.
Initialize
server before calling mock-start helper
_start_mock_server(...) can raise RuntimeError (for example when the chosen port is grabbed between selection and bind), and in that case this assignment never completes, so the finally: server.terminate() path raises UnboundLocalError and masks the real failure. This makes intermittent CI startup issues much harder to diagnose and affects all three tests that use this try/finally pattern with _start_mock_server.
Useful? React with 👍 / 👎.
Summary
Validation