CMake build system rework #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is now a separate CMake file in src defining the library. The library target is then used to build the executable.
This creates a relocatable install directory with a relative RPATH, and thus allows the executables to find the libraries without setting e.g. LD_LIBRARY_PATH on Linux.
Also removed trailing spaces.
Author
|
Also, I use a devcontainer locally, but I haven't committed its configuration files. Let me know if you'd like to have them in the repository, I'd be happy to share them! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @ZeppSav!
I've slightly improved the CMake setup. It now includes the GUI (optionally), and installation targets.
Note: When building with CMake, the GUI executable has a different name (
BEMUse_GUI) than the CLI executable (BEMUse).I've also been thinking about doing the following, let me know if you'd be interested and I'll implement them:
BEMUseConfig.cmake) to make the installation directly usable by CMake.Also, I've used Qt6 in CMake, what version do you usually use? I can add a fallback to an older version if Qt6 is not found.