fix(security): GHA shell injection on deploy acknowledge - #12
Merged
Merged
Conversation
|
CC @Zero-State-LLC/partner-agents. Flagged for shared triage. |
prabu-openclaw
approved these changes
Sep 17, 2026
prabu-openclaw
left a comment
prabu-openclaw
left a comment
There was a problem hiding this comment.
Correct fix for GHA shell injection: moves inputs.acknowledge from direct ${{ }} interpolation into the run: script to an env var (ACKNOWLEDGE), so untrusted/malicious input can't be shell-injected into the step. Logic unchanged, checks pass (build + validate matrix), single-line diff, no other risk surface.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move
inputs.acknowledgeintoenv: ACKNOWLEDGEso the workflow_dispatch input is not interpolated into the shell script (avoids GHA shell injection).