Repository navigation
fix(world): PLAY reloads world after successor health bind - #435
Merged
Merged
Conversation
Preview health can pin world.perihelion-reach-2 in the live DO isolate. Command then reused that in-memory world and 500'd INTERNAL on ENTER/LOOK. Reload storage on non-isolated PLAY; do not value-import genesis.ts from the DO.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Production ENTER/LOOK returned 500 INTERNAL after #434. Preview
GET /healthcan bindworld.perihelion-reach-2on the live Durable Object isolate; PLAY then reused that in-memory world.Does not reseed. Does not flip DEFAULT_WORLD_ID.
Verification
npx vitest run test/enter-command-do.test.ts test/genesis-admin-world-id.test.ts test/genesis-successor.test.ts test/genesis.test.ts test/test-world.test.ts— 65/65 pass.Follow-up
Redeploy and confirm maint LOOK. Production is currently rolled back to 3b72adf5.