Repository navigation
docs: give camera geometry its own requirement id - #78
Merged
Merged
Conversation
Saved keeps FR-050, which the apps already cite, and the row now matches #65: canonical codes only, no thumbnail, cleared by account.clear_saved and account deletion. Camera pairing moves to FR-052. SC-4 cites FR-004, FR-005, and FR-045 for deleting the temporary photo. The adapter stays proposed until #77.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 879c4ab2b3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
specs/001-zzthat-apps/spec.mdhad two FR-050 rows. Saved keeps FR-050, because tasks, runtime, and both apps already cite it. The row now matches what #65 shipped: canonical codes only, no photo and no thumbnail, cleared byaccount.clear_savedand by account deletion.account.unhide_alldoes not clear Saved.Camera pairing moves to FR-052, the next free id after FR-051. The fiducial sentences cite FR-052. SC-4's photo-deletion cite drops FR-050. Deletion is FR-004; FR-005 and FR-045 stay as the no-upload rules.
recognition-adapter.mdno longer says zzThis #89 is an unmerged draft. The contract is proposed until zzThat #77 is answered. This PR does not start T023 to T025.Related issue or project item
Board: https://github.com/orgs/Zero-State-LLC/projects/25
zzThat #60 and #61 (acceptance checked against #65). zzThat #77 stays the gate for adapter code.
Testing performed
python3 scripts/lint-specs.pyNo app code change. No em dash or en dash in the added lines.
Collaboration checklist