Skip to content

ci: skip unrelated label events without cancelling real runs; ZZDesign tests in the ios job - #82

Merged
scrimshawlife-ctrl merged 1 commit into
mainfrom
ci/label-filter-zzdesign
Oct 17, 2026
Merged

scrimshawlife-ctrl merged 1 commit into
mainfrom
ci/label-filter-zzdesign

Conversation

@kneelbeforez0D

Copy link
Copy Markdown
Collaborator

From the 2026-10-16 zzThat audit.

  • Unrelated labels. Adding any label used to rerun Apps CI, and the per-PR cancel-in-progress then cancelled the real run: 26 of the last 82 runs were cancelled duplicates (for example Point T096 at the merged unknown-enum half #80). Now a labeled event for a label other than ios-ci skips every job and runs in its own concurrency group, so it can't cancel anything. Apps E2E does the same for labels other than run-e2e or ios-ci.
  • ZZDesign. The ios job now runs the ZZDesign package tests, which CI never ran before.
  • ci.yml: the header comment no longer says apps-ci.yml "is added by the build".

Not changed (your call: ZQ27 spend): the ios job still runs only with the ios-ci label or by hand. So #63, #64, #65, #76 and #79 merged iOS code with iOS CI skipped, and main is never re-tested after a merge. Options:

  • (a) run ios on push to main, about one macOS run per merge;
  • (b) require ios-ci on PRs that touch apps/ios/**;
  • (c) keep it as is.

Recommend (a).

The YAML parses and lint-specs.py passes. Actions behavior can only be confirmed on GitHub.

🤖 Generated with Claude Code

…m; ZZDesign tests in the ios job

Adding a label other than ios-ci (apps-ci) or run-e2e/ios-ci (apps-e2e)
skips every job and uses its own concurrency group, so it no longer
cancels or duplicates the pull request's real run (26 of 82 Apps CI runs
were cancelled duplicates). The ios job also runs the ZZDesign package
tests. ci.yml's header comment no longer says apps-ci is to be added.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@scrimshawlife-ctrl scrimshawlife-ctrl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by Danny 2026-10-16 23:57 PT

@scrimshawlife-ctrl
scrimshawlife-ctrl merged commit 0135788 into main Oct 17, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants