Fix force termination access denied crash - #2
Merged
Merged
Conversation
ZheLZZ
marked this pull request as ready for review
August 6, 2026 07:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
AggregateExceptionwhen Windows cannot terminate every process in a process tree.AccessDeniedresult so TrayTidy can continue into its administrator-elevation flow instead of terminating the WPF application.0.2.1-beta.Why
Process.Kill(entireProcessTree: true)can throw anAggregateExceptionwhose inner exception is Win32 error 5 (Access is denied). The previous implementation caught only a directWin32Exception, so the wrapped error bypassed the administrator-elevation branch, reached the WPF dispatcher, displayed a fatal interface-error dialog, and exited TrayTidy.User impact
Protected or privileged background processes now follow the expected Windows administrator-confirmation path. If Windows or a termination provider returns another unexpected error, TrayTidy reports the individual operation as unsuccessful without closing the whole application.
This change does not alter recommendation scores, default selections, protection rules, process-identity validation, foreground-window checks, modal-dialog checks, or the requirement for explicit user confirmation before force termination.
Validation
win-x64publish completed successfully with product version0.2.1-beta.