Skip to content

fix: retry failed LLM requests at the bridge layer - #63

Closed
Chumor wants to merge 1 commit into
Zhou-Shilin:mainfrom
Chumor:fix/issue-58-retry
Closed

Chumor wants to merge 1 commit into
Zhou-Shilin:mainfrom
Chumor:fix/issue-58-retry

Conversation

@Chumor

@Chumor Chumor commented Aug 6, 2026 •

Copy link
Copy Markdown
Collaborator
  • Retry provider exceptions and assistant errors with one bridge policy
  • Resume failed harness turns and prevent duplicate streaming output

Fixes #58

Summary by CodeRabbit

  • Bug Fixes
    • Improved reliability when completions and ongoing tasks encounter temporary failures.
    • Added controlled retries with increasing delays, retry limits, and cancellation support.
    • Prevented duplicate or conflicting streamed output during retry attempts.
    • Preserved conversation and extension state when recovering from failed tasks.
    • Retry settings are refreshed for each task session.
    • Final failures are clearly reported instead of leaving incomplete results.

@coderabbitai

This comment was marked as resolved.

coderabbitai[bot]

This comment was marked as outdated.

@Chumor
Chumor marked this pull request as draft August 6, 2026 14:15
@Chumor
Chumor marked this pull request as ready for review August 6, 2026 15:07
@Chumor
Chumor force-pushed the fix/issue-58-retry branch from d32ad33 to bf45808 Compare August 6, 2026 15:07
@Chumor

Chumor commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

@coderabbitai

This comment was marked as resolved.

coderabbitai[bot]

This comment was marked as resolved.

- Retry provider exceptions and assistant errors with one bridge policy
- Resume failed harness turns and prevent duplicate streaming output
@Chumor
Chumor force-pushed the fix/issue-58-retry branch from bf45808 to 7c2893e Compare August 6, 2026 16:27
@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

@Chumor
Chumor requested a review from Zhou-Shilin August 6, 2026 16:36
@Zhou-Shilin

Copy link
Copy Markdown
Owner

Hi @Chumor! Thank you for taking the time to open this pull request. However, I am going to close it as the proposed fix is applied in the wrong location and introduces critical issues. During our testing, sending a message caused an immediate crash on iOS, and the reconnect logic failed to take effect on Android. Since similar issues have come up previously, I kindly ask that you thoroughly test all changes on real devices before submitting future pull requests, especially when utilizing AI tools to generate code. We appreciate your efforts and understanding~

@Zhou-Shilin Zhou-Shilin closed this Aug 7, 2026
@Chumor
Chumor deleted the fix/issue-58-retry branch August 16, 2026 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Reconnect mechanism for LLM API requests fails on Android and iOS

2 participants