Skip to content

improve pull request checks and nightly Android builds - #77

Merged
Zhou-Shilin merged 5 commits into
Zhou-Shilin:mainfrom
Chumor:ci/builds
Sep 19, 2026
Merged

Zhou-Shilin merged 5 commits into
Zhou-Shilin:mainfrom
Chumor:ci/builds

Conversation

@Chumor

@Chumor Chumor commented Sep 6, 2026 •

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Chores
    • Nightly Android builds now include changes from extensions and use release-style settings for more consistent app behavior.
    • Pull request validation now runs exclusively for pull requests and covers Android, iOS, Pi Bridge, and extensions.
    • Automated checks now include Node validation, Android checks with improved caching and time limits, and iOS simulator builds.

@coderabbitai

coderabbitai Bot commented Sep 6, 2026 •

Copy link
Copy Markdown

Review Change StackReview Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 66e9082a-7f8c-4e4c-88a5-befe1e9a9701

📥 Commits

Reviewing files that changed from the base of the PR and between 091d855 and 4dbd72d.

📒 Files selected for processing (2)
  • .github/workflows/pr-check.yml
  • app/build.gradle.kts

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.


📝 Walkthrough

Walkthrough

The workflows now route extension and Node.js changes to updated validation jobs. The nightly APK workflow adds Node.js setup. The nightly Android build type now derives from release configuration.

Changes

CI and build updates

Layer / File(s) Summary
Path-filtered validation
.github/workflows/pr-check.yml
The PR workflow removes manual dispatch, updates path filtering, includes extension changes, and adds conditional Pi Bridge and Extension API checks.
Platform check execution
.github/workflows/pr-check.yml
Android checks add Node.js setup, read-only Gradle caching, and a timeout. iOS checks update actions, use read-only caching, and run simulator tests.
Nightly build configuration
.github/workflows/build-nightly-apk.yml, app/build.gradle.kts
The nightly APK workflow responds to extension changes and configures Node.js. The nightly build type now derives from release, while debug receives application and manifest settings.

Priority: ➖ Normal

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Feature

Sequence Diagram(s)

sequenceDiagram
  participant PullRequest
  participant PathsFilter
  participant ValidationJobs
  PullRequest->>PathsFilter: Evaluate changed paths
  PathsFilter->>ValidationJobs: Select Node.js, Android, and iOS checks
  ValidationJobs->>ValidationJobs: Run platform and package validation
Loading

Suggested reviewers: zhou-shilin

Merge Risk: 🟡 Moderate · up to 4dbd7

CI behavior can change without a repository update because several workflow actions are not pinned to immutable commits.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the two main changes: improved pull request checks and updated nightly Android builds.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

coderabbitai[bot]

This comment was marked as resolved.

@Chumor
Chumor force-pushed the ci/builds branch 2 times, most recently from 2e5b0cc to 4f2a765 Compare September 6, 2026 05:18
coderabbitai[bot]

This comment was marked as off-topic.

- Remove manual workflow dispatch and run checks only for pull requests
- Select Android, iOS, and Node checks from their actual changed inputs
- Update action versions and keep CI dependency caches read-only
- Use a .debug application ID suffix for debug builds without production conflicts
- Build nightly artifacts from release settings with nightly signing when available
coderabbitai[bot]

This comment was marked as resolved.

Repository owner deleted a comment from coderabbitai Bot Sep 6, 2026
Repository owner deleted a comment from coderabbitai Bot Sep 6, 2026
Repository owner deleted a comment from coderabbitai Bot Sep 6, 2026
@Chumor

Chumor commented Sep 19, 2026

Copy link
Copy Markdown
Collaborator Author

@Zhou-Shilin Looks good to me. This PR is ready to merge.

@Zhou-Shilin
Zhou-Shilin merged commit 54583f2 into Zhou-Shilin:main Sep 19, 2026
5 checks passed
@Chumor
Chumor deleted the ci/builds branch September 19, 2026 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants