fix: deliver Termux RUN_COMMAND results via pending intent - #80
Conversation
- Start RunCommandService as a foreground service from the background - Bind the result broadcast to the application context - Keep the result receiver alive until the plugin result bundle is applied
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 2 remain after this review. 📝 WalkthroughWalkthroughThe Termux command flow now uses application context for result delivery, attempts foreground-service startup with fallback handling, and keeps broadcast processing active until result handling finishes. ChangesTermux execution lifecycle
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ContextCompat.startForegroundService() is void here, so the try/catch was inferred as Any? and failed Kotlin compile.
|
Hi @Zhou-Shilin, please review this PR when you have a chance. If everything looks good, please squash and merge it. |
5bd3657 to
b2e81d5
Compare
Refs:
Summary by CodeRabbit