Show the impact map when the CARTO basemap is blocked - #10
Merged
Merged
Conversation
Load OpenFreeMap dark tiles instead of CARTO style.json, fall back to a local dark canvas if that style also fails, and ignore aborted tile fetches so they no longer cover the map.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The live map showed a yellow
AJAXError: Failed to fetch (0)banner over a blank canvas because the CARTO Dark Matter style URL never loaded in the browser. The map now uses OpenFreeMap dark tiles, and if that style also fails it falls back to a local dark canvas so impact rings still draw.This does not change the impact physics, NASA/JPL data, or casualty copy.
Verified with
npx tsc --noEmit,npx eslint .,npm test(66/66),npm run build, and a local browser run: OpenFreeMap tiles loaded, NYC streets rendered, a Chelyabinsk scenario drew rings, and the AJAXError overlay did not appear.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.