Open the map on the user's location - #11
Merged
Merged
Conversation
Stop treating a missing URL as 0,0 in the ocean. Request browser geolocation on first visit, fall back to a curated city for the timezone, and leave real shared links alone.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First visit no longer opens on 0,0 in the ocean. The map asks for browser location and, if that is denied, uses a curated city for the timezone (Tel Aviv for Asia/Jerusalem; New York if unknown). Shared links with real coordinates stay put; the old
lat=0.00000&lng=0.00000poison URLs do not.Verified with
npx tsc --noEmit, focused ESLint,npm test(78/78),npm run build, and a local browser run: timezone fallback landed on Tel Aviv, GPS upgraded to Westminster, and a New York share link was not overwritten.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.