Skip to content

fix setup.py to install pycrypto correctly#15

Open
thecodingshrimp wants to merge 2 commits intoZokrates:masterfrom
thecodingshrimp:fix_setup_py
Open

fix setup.py to install pycrypto correctly#15
thecodingshrimp wants to merge 2 commits intoZokrates:masterfrom
thecodingshrimp:fix_setup_py

Conversation

@thecodingshrimp
Copy link

@thecodingshrimp thecodingshrimp commented Mar 5, 2022

Problem

zokrates_pycrypto is not correctly installed with pip install git+git://github.com/Zokrates/pycrypto since dependencies are not installed.

Reproduction

$ python3 -m venv venv
$ . venv/bin/activate
$ python3 setup.py install
$ python3
$ from zokrates_pycrypto.gadgets.pedersenHasher import PedersenHasher
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File ".../zokrates_pycrypto/gadgets/pedersenHasher.py", line 2, in <module>
    import bitstring
ModuleNotFoundError: No module named 'bitstring'

Reason

setup.py did not include required packages from requirements.txt and therefore did not install the package zokrates_pycrypto correctly.

What changed

  • bitstring==3.1.5 requirement was now added to setup.py
  • .gitignore now features all possible python workspace files
  • removed requirements.txt since it is replaced by setup.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant