Skip to content

[Fix] Accessibility contrast checks fail during theme changes - #1613

Merged
edelauna merged 1 commit into
mainfrom
fix/contrast-test-stability-17rd6uqphf9tz
Sep 12, 2026
Merged

[Fix] Accessibility contrast checks fail during theme changes#1613
edelauna merged 1 commit into
mainfrom
fix/contrast-test-stability-17rd6uqphf9tz

Conversation

@zoomote

@zoomote zoomote Bot commented Sep 12, 2026

Copy link
Copy Markdown
Contributor

​Created by Roomote. Follow up by mentioning @roomote, in the web UI, or in Discord.

Related GitHub Issue

Closes: #1612

Description

Disable CSS transitions within the accessibility contrast audit before applying each VS Code theme. Contrast measurements now sample final theme colors deterministically while retaining the existing WCAG thresholds, including the 4.5:1 text requirement.

This is test-harness-only and does not change extension behavior or rendered UI.

Test Procedure

  • pnpm exec playwright test -c playwright-ct.config.ts src/components/ui/__tests__/AccessibilityContrast.visual.tsx --repeat-each=10 --ignore-snapshots from webview-ui/ (40/40 passed across four themes)
  • pnpm test from the repository root (10/10 Turbo tasks passed)
  • pnpm exec eslint --max-warnings=0 src/components/ui/__tests__/AccessibilityContrast.visual.tsx from webview-ui/
  • pnpm check-types from webview-ui/
  • Commit and push hooks also passed repository-wide lint and type checks.

Host snapshot comparisons were intentionally excluded from the repeated focused run because committed visual baselines are Docker-authored; this change does not alter snapshots or rendered final states.

Pre-Submission Checklist

  • Issue Linked: This PR is linked to an approved GitHub Issue (see "Related GitHub Issue" above).
  • Scope: My changes are focused on the linked issue (one major feature/fix per PR).
  • Self-Review: I have performed a thorough self-review of my code.
  • Testing: New and/or updated tests have been added to cover my changes (if applicable).
  • Visual Snapshot (UI changes only): If a user would notice this change at a glance (layout, theme tokens, brand elements, empty/error states), I've added or updated a *.visual.tsx snapshot in webview-ui/. See webview-ui/AGENTS.md -> "When a UI change needs a snapshot".
  • Documentation Impact: I have considered if my changes require documentation updates (see "Documentation Updates" section below).
  • Contribution Guidelines: I have read and agree to the Contributor Guidelines.

Visual Snapshots

Not applicable. Final rendered UI is unchanged; this only removes transition timing from the test harness.

Videos (interaction / animation only)

Not applicable.

Documentation Updates

  • No documentation updates are required.
  • Yes, documentation updates are required.

Additional Notes

The contrast assertion implementation and thresholds are unchanged, so final colors below the required ratio continue to fail.

Get in Touch

Mention @roomote on this PR for follow-up.

@coderabbitai

coderabbitai Bot commented Sep 12, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • coderabbit-review-active

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: ba99b9db-d787-4bb9-b940-9209c1f845c1

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Sep 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@edelauna
edelauna marked this pull request as ready for review September 12, 2026 02:41
@edelauna
edelauna enabled auto-merge September 12, 2026 02:41
@github-actions

github-actions Bot commented Sep 12, 2026

Copy link
Copy Markdown
Contributor

Review status

This PR was opened by an automated account. A human maintainer must verify the change intent, provenance, and validation before merging.

Current step: The required review sequence passed. Remaining merge requirements apply.

Review-state labels are managed by this workflow; do not edit them manually.

@edelauna
edelauna added this pull request to the merge queue Sep 12, 2026
Merged via the queue into main with commit 87d41aa Sep 12, 2026
33 checks passed
@edelauna
edelauna deleted the fix/contrast-test-stability-17rd6uqphf9tz branch September 12, 2026 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Stabilize flaky accessibility contrast test after theme changes

2 participants