[Fix] Mutation warnings appear twice after drafts become ready - #1645
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 4 included reviews per hour; 2 remain after this review. 📜 Recent review details🧰 Additional context used📓 Path-based instructions (3)Check strict typing and exhaustive behavior across normal, boundary, error, cancellation, retry, and compatibility paths.⚙️ CodeRabbit configuration file Files:
Require full commit SHA pins, least-privilege permissions, safe expression and shell interpolation, and trusted metadata handling.⚙️ CodeRabbit configuration file Files:
Act as an adversarial second-opinion reviewer.⚙️ CodeRabbit configuration file Files:
📝 SummarySummary by CodeRabbit
WalkthroughThe mutation-diff job now skips draft pull requests while running for merge queue events. Tests verify the workflow trigger types, draft filtering, non-draft pull request actions, and merge queue execution. ChangesMutation testing workflow
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The workflow and tests cover draft, reviewable pull-request, and merge-queue execution without identified merge-blocking risk. 🚥 Pre-merge checks | ✅ 7 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (7 passed)
Full details: Description checkExplanation The description explains what changed, why the change was needed, and the expected impact. It does not provide the required approved GitHub Issue link, detailed Test Procedure, pre-submission checklist, or documentation assessment.
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Review statusThis PR was opened by an automated account. A human maintainer must verify the change intent, provenance, and validation before merging. Current step: The required review sequence passed. Remaining merge requirements apply. Review-state labels are managed by this workflow; do not edit them manually. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
What changed
Changed-code mutation testing now skips pull-request jobs while the PR is a draft. It starts when the PR becomes ready and continues to run for reviewable opens, new commits, reopens, and merge-queue checks.
Focused workflow tests model the draft-open to ready transition and preserve the supported reviewable event paths.
Why this change was made
PR #1644 showed GitHub retaining annotations from both the draft-open run and the ready-for-review run for the same head SHA. Within-run warning deduplication cannot remove annotations belonging to an earlier workflow run.
Impact
Draft PR creation no longer emits mutation annotations that GitHub can display again beside the ready-for-review results. Mutation enforcement remains unchanged once a PR is reviewable and in the merge queue.