Skip to content

fix: add hideTrendIcon prop to StatCard for non-numeric trends (#158)#1

Open
devin-ai-integration[bot] wants to merge 1 commit into
mainfrom
devin/1779720339-fix-statcard-trend-icon
Open

fix: add hideTrendIcon prop to StatCard for non-numeric trends (#158)#1
devin-ai-integration[bot] wants to merge 1 commit into
mainfrom
devin/1779720339-fix-statcard-trend-icon

Conversation

@devin-ai-integration
Copy link
Copy Markdown

Summary

Fixes ANYTECHS#158StatCard was always rendering a TrendingUp or TrendingDown icon next to the trend text. On the Earnings page, the "Pending Payout" and "Tax Ready" cards use non-numeric trend strings ("Processing" and "Exportable"), making the trend icon visually misleading.

Changes:

  • Added an optional hideTrendIcon boolean prop to StatCard (defaults to false)
  • When hideTrendIcon is true, no TrendingUp/TrendingDown icon is rendered — only the trend text is shown
  • Applied hideTrendIcon to the "Pending Payout" and "Tax Ready" stat cards on the Earnings page
  • Existing stat cards with numeric trends (e.g. +12.5%, +8.2%) are unaffected

Review & Testing Checklist for Human

  • Navigate to the Earnings page and verify "Pending Payout" shows Processing without a trend icon
  • Verify "Tax Ready" shows Exportable without a trend icon
  • Verify "Total Earned" and "Completed" cards still show their trend icons (TrendingUp)
  • Navigate to the Dashboard page and verify the 3 stat cards there still render trend icons as before

Notes

Minimal, targeted change — only 2 files modified. No new dependencies introduced.

Link to Devin session: https://app.devin.ai/sessions/6c8be1f0e8244898a5cd734f2bdc92c1
Requested by: @ZuLu0890

- Add optional hideTrendIcon boolean prop to StatCard component
- When hideTrendIcon is true, no TrendingUp/TrendingDown icon is rendered
- Apply hideTrendIcon to Pending Payout and Tax Ready cards on Earnings page
- Existing stat cards with numeric trends remain unaffected

Fixes ANYTECHS#158

Co-Authored-By: Praise Ayodele <ayodelepraise2000@gmail.com>
@devin-ai-integration
Copy link
Copy Markdown
Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

StatCard renders a trend icon for non-numeric trend values

1 participant