fix: add hideTrendIcon prop to StatCard for non-numeric trends (#158)#1
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
fix: add hideTrendIcon prop to StatCard for non-numeric trends (#158)#1devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
- Add optional hideTrendIcon boolean prop to StatCard component - When hideTrendIcon is true, no TrendingUp/TrendingDown icon is rendered - Apply hideTrendIcon to Pending Payout and Tax Ready cards on Earnings page - Existing stat cards with numeric trends remain unaffected Fixes ANYTECHS#158 Co-Authored-By: Praise Ayodele <ayodelepraise2000@gmail.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes ANYTECHS#158 —
StatCardwas always rendering aTrendingUporTrendingDownicon next to the trend text. On the Earnings page, the "Pending Payout" and "Tax Ready" cards use non-numeric trend strings ("Processing"and"Exportable"), making the trend icon visually misleading.Changes:
hideTrendIconboolean prop toStatCard(defaults tofalse)hideTrendIconistrue, noTrendingUp/TrendingDownicon is rendered — only the trend text is shownhideTrendIconto the "Pending Payout" and "Tax Ready" stat cards on the Earnings page+12.5%,+8.2%) are unaffectedReview & Testing Checklist for Human
Processingwithout a trend iconExportablewithout a trend iconTrendingUp)Notes
Minimal, targeted change — only 2 files modified. No new dependencies introduced.
Link to Devin session: https://app.devin.ai/sessions/6c8be1f0e8244898a5cd734f2bdc92c1
Requested by: @ZuLu0890