Skip to content

Improve encounter history, event tracker discovery, and chat TTS - #171

Merged
Zudin987 merged 29 commits into
mainfrom
feat/encounter-attribute-averages-20260922
Sep 27, 2026
Merged

Zudin987 merged 29 commits into
mainfrom
feat/encounter-attribute-averages-20260922

Conversation

@Zudin987

@Zudin987 Zudin987 commented Sep 22, 2026 •

Copy link
Copy Markdown
Owner

Scope

  • Reuse the existing offline Encounter History and A/B comparator; no DPS simulator or graph.
  • Add observed character-attribute summaries (initial / time-weighted average / last observed / coverage) to saved DPS rows, with backward-compatible serde defaults.
  • Capture stats from existing sanitized combat snapshots and avoid inventing unavailable zero or late-capture initial values.
  • Add an Attributes tab and same-player A/B stat deltas, retaining existing skill, damage and Imagine comparisons.
  • Regression tests for weighting, duplicate samples, boundaries and legacy saves.

Follow-up fixes from Windows CI and review

  • Add a checked-in generated-source builder to initialize DpsRow.encounter_attributes, resolving Rust E0063.
  • Use a delegated change handler so the Attributes A/B panel continues updating when the comparison player selector recreates itself on each selection; add a regression assertion.

Verification

  • Latest head: 40d3676122a0227366ab3ea3c542febe0e72d9b0.
  • Windows Rust CI run #805 completed successfully: unit/regression tests, Clippy, native release build, EXE smoke test, size budget, packaging, generated-source diagnostics and native UI render diagnostics.
  • Actual in-game packet validation and interactive browser selection checks remain outstanding. Averages are snapshot-sampled rather than exact per-attribute packet timelines; coverage is displayed.

Keep this draft until real-game validation. No release intended yet.

@Zudin987
Zudin987 marked this pull request as ready for review September 27, 2026 12:03
@Zudin987 Zudin987 changed the title Add measured initial, average and final attributes to encounter history and A/B comparison Improve encounter history, event tracker discovery, and chat TTS Sep 27, 2026
@Zudin987
Zudin987 merged commit 10b9787 into main Sep 27, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant