Drop uiop as a primary dependency#82
Conversation
7092d13 to
7ee7232
Compare
|
Hi, any thoughts? |
| (stringify-to stream) | ||
| nil))))) | ||
|
|
||
| ;; NOTE: Borrowed from UIOP. |
There was a problem hiding this comment.
Did you check uiop's licence to see if it was ok to grab code from it?
There was a problem hiding this comment.
Seems to be MIT, which I interpret to mean "do whatever you want" (see https://opensource.org/license/mit).
|
I never remember the exact condition (not cl:condition 😅), but doesn't asdf complain (signals a warning) when there are multiple system files in the same directory? |
|
As in, multiple |
|
No problems from me. The tests are failing but I'm guessing that's due to some incompatible update to SBCL - I'll need to update the version used for tests |
FYI you're probably thinking of two system definitions in the same file - ASDF would want them named in a specific way, |
Removing
UIOPas a main dependency reduces final binary sizes but also improves compatibility in certain scenarios (WASM).This PR also moves the
.asdfiles to match convention, but I'm happy to undo that if you prefer them where they were.