Conversation
| end | ||
|
|
||
| def do_attachment | ||
| if Event.decrease_ticket_number(@order) |
There was a problem hiding this comment.
Trochę pachnie mi to programowaniem strukturalnym opakowanym w modele. Tzn. klasa Event musi wiedzieć wszystko o tym jak działają zamówienia, żeby móc zrealizować tę metodę. Zostawię tu propozycję tego jak ja bym to zrobił, ale nie trzeba się do tego stosować. Głównie chodzi o to, że metody mają tylko jedną odpowiedzialność i nie wiedzą za dużo o całym procesie.
class Order
def items_available?
order_item.all? { |item| item.available? } # przydatna metoda https://ruby-doc.org/core-2.5.1/Enumerable.html#method-i-all-3F
end
def decrease_tickets_amount!
order_item.each do |item|
item.decrease_amount!
endclass OrderItem
def available?
(event.amount - amount) >= 0
end
def decrease_amount!
event.decrease_amount_by!(amount)
endclass Event
def decrease_amount_by!(number)
update!(amount: amount - number)
enddef do_attachment
if @order.items_available?
@order.decrease_tickets_amount!
@order.update owner: current_user
else
# ta część tak smao jak u Pana| end | ||
|
|
||
| def filter_events(cat) | ||
| @results = if cat.nil? |
There was a problem hiding this comment.
if cat.blank? obsłuży zarówno cat == '' jak i cat.nil?
| cart = current_guest.cart | ||
| cart.update status: Order::PENDING_STATUS | ||
|
|
||
| cart.confirm |
|
|
||
| def confirm | ||
| update price: event.price | ||
| end |
There was a problem hiding this comment.
Fajne, obiektowe programowanie. Każdy obiekt ma określoną odpowiedzialność.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.