fix(coverage): use atomic counters for worker threads - #219
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenWrt QEMU coverage intermittently fails with negative counts in proxy.c when worker threads update shared gcov counters. Compile coverage builds with -fprofile-update=atomic and keep lcov negative-count validation enabled.
Validation: GCC 14.2 passes all 123 existing tests and real REDIRECT/TPROXY netns integration; Clang 20 accepts the flag. In 100 real worker startup/shutdown cycles plus netns tests, both builds recorded 1,604 worker entries. The original build recorded only 3,207 listener calls (expected 3,208); the atomic build recorded all 3,208 and passed lcov. This local run demonstrated lost counts without reproducing the negative-count error itself.
Historical QEMU runs 34099489032 and 32688567132 show the same negative-count failure before the dependency update. Both OpenWrt 24.10.8 and 25.12.5 QEMU jobs now pass, including strict lcov generation and coverage upload.