add devcontainer file and define path for utils.py#76
Conversation
Robinlovelace
left a comment
Robinlovelace
left a comment
There was a problem hiding this comment.
Looks good to me. Cc @dabreegster
| # Ensure cargo command is available | ||
| command -v cargo | ||
|
|
||
| # Install odjitter using cargo |
There was a problem hiding this comment.
Why are we doing anything with odjitter at all?
There was a problem hiding this comment.
Probably from a different container definition that was copied-across.
There was a problem hiding this comment.
have removed it from postCreateCommand.sh
|
|
||
| from utils import * | ||
| # Add the parent directory to the system path | ||
| sys.path.insert(0, os.path.abspath(os.path.join(os.path.dirname(__file__), ".."))) |
There was a problem hiding this comment.
There should be symlinks for all the examples to make utils.py work. Is it not working in the devcontainer for some reason?
There was a problem hiding this comment.
ye, this "../utils.py" not working in the devcontainer
There was a problem hiding this comment.
I added a comment explaining this
dabreegster
left a comment
dabreegster
left a comment
There was a problem hiding this comment.
I pushed some changes, please confirm they're all fine, and then I'll merge. Thanks for the PR!
|
|
||
| from utils import * | ||
| # Add the parent directory to the system path | ||
| sys.path.insert(0, os.path.abspath(os.path.join(os.path.dirname(__file__), ".."))) |
There was a problem hiding this comment.
I added a comment explaining this
| sudo make install | ||
| tippecanoe --version | ||
|
|
||
| # Add local instance of odjitter to the /usr/local/bin directory: |
There was a problem hiding this comment.
Missed this part, I removed it
3 participants
No description provided.