77 weighted points#82
Conversation
Robinlovelace
commented
Sep 24, 2024
- Add york_minimal, copied from york example as starting point
- Visualise basic inputs (hide output files)
|
Weighted points added: @dabreegster OK to add the minimal input files? They are tiny, with 9 subpoints as shown above. |
Update to make destinations points
|
In terms of trying to run |
| "destinations_path": "destinations.geojson" | ||
| }, | ||
| "uptake": "Identity", | ||
| "cost": { |
There was a problem hiding this comment.
It'd be simpler to not use a custom external command for lts and cost in this example. That's causing the Docker issue, and other examples demonstrate how to do this already. How about following the Liverpool example for cost and lts? Do you want something like quiet routes for this, just distance / direct roues, or something else?
There was a problem hiding this comment.
Yeah, simple is good, clearly just copy-pasted from previous York example. Can update that, good suggestion.
There was a problem hiding this comment.
- I want to carve out really clear terminology in this project, and "subpoints" does not seem ideal. Since these are used as origins, what about
origins.geojson? - The property needs to be called
weight, notsize. I need to document this still
There was a problem hiding this comment.
No objection to origins.geojson, other than slight name clash with 'zones of origin': you can have zones in which flows originate and origins that specificy the exact points they must flow from. But as long as it's documented could well be the least bad options, I have no better suggestions, and happy with origins.geojson if you are. Subpoints comes from the jittering paper and it seems we're using the word in a similar way, what's the objection to subpoints out of interest?
👍 to clarify terms upfront and happy to adapt.
| ] | ||
| ) | ||
|
|
||
| def makeZones(): |
There was a problem hiding this comment.
Since the files are checked into git directly, we don't need these two. Actually, I want to revisit this in the York example, where it's copied from. Not sure why I chose to do it that way...
There was a problem hiding this comment.
Yeah it's a bit of an unusual way of creating a GeoJSON, why not just include the .geojson as a config! OK to wait for the York example to be updated before updating this?
There was a problem hiding this comment.
I'm hesitant to check both qmd and md into git, because the second is derived from the first, and it contains lots of log-spam. Looking at https://quarto.org/docs/publishing/github-pages.html, checking in both is option 1, right? Publishing to GH Pages is more work upfront, but feels like the better option. I can set that up after we get this first PR merged?
There was a problem hiding this comment.
Sure, happy to remove the .md. Glad I didn't check in the rest of the stuff that quarto outputs based on this comment!
| python setup.py | ||
| ``` | ||
|
|
||
| We'll get a sample of 2 schools in York (York High School and Huntington School) using the `osmextract` package. |
There was a problem hiding this comment.
I'm fine showing examples like this here, but FWIW, something like Overpass can be quicker/more interactive. Ultimately a user guide could point to a variety of methods for generating inputs like this. https://overpass-turbo.eu/s/1RL9 as an example
There was a problem hiding this comment.
Yes Overpass is fine for this also. Happy for this to be tweaked, just using what I know best. I don't think it matters here but happy to use another tool to get the schools if there are ways of doing that with reproducible and readable code. Doesn't seem like a biggy or blocker at this stage but let me know if you'd like to see changes to this bit.



