Smoother rendering via rendering hints #112
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the signture panel when the pdf document and the signature preview is rendered, we add antialiasing and bicubic interpolation, so the scaled images dont look jagged and much smoother. I also added constant for a magic value that was used to upscale the signature preview image.
Author
|
Hey @iaik-jheher, I saw that you merged #111 today, I fixed the resulting merge conflicts and now it should be good again. |
Contributor
|
Rebase/force push is fine, but not required, we'll squash merge eventually anyway. |
Contributor
|
Just so I don't leave you hanging indefinitely without update: this is very much still on my radar, but we've run into some internal concerns about (re-)licensability of external contributions, which is what's blocking me from reviewing this right now. I'll let you know once I know more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the signture panel where the pdf page and the signature preview is painted, I added antialiasing and bicubic interpolation rendering hints so the scaled images don't look as jagged and much smoother. Specifically I added bicubic filtering, anti aliasing and setting the preferred rendering to the quality setting. I also added a constant for the magic value that was used to downscale the signature preview image in
SignaturePanel.setSignaturePlaceholder(...). It was used because when we request a signature preview fromPdfAs.generateVisibleSignaturePreview(...)we upscaled the resolution by that factor. I guess downscaling to get better image quality was already an idea. I reduced the scaling from 4 to 2 because this seemed to give nicer results.I tested that it compiles with
mvn -U install.In the future I might add a setting to modify the filtering settings, because somebody out there might be running this on weak hardware and prefers speed over looks.
I included two screenshots of the difference in rendering so one can easily compare them, I think it looks better ;)
