fix: endpoint number parsing error#224
Merged
a1ien merged 2 commits intoa1ien:masterfrom Dec 29, 2025
Merged
Conversation
added 2 commits
December 27, 2025 09:59
Fixed a bug in parsing the ndpoint number from the address field in endpoint descriptor. According to the USB device specification, bits 0-3 of the address field in the endpoint descriptor represent the endpoint number. Therefore, when parsing the number from the address, it should be masked with 0xf instead of 0x7. Incorrect parsing will lead to corrupted device endpoint information.
According to previous fix for endpoint number parsing commit, related unit test needs to be fix as well.
Author
|
@a1ien Many thanks to the rusb library, which has been a great help in building passthrough device features in our virtual machine project. However, recently, while troubleshooting a passthrough failure, I noticed that the logic in the code attempting to obtain the endpoint number by parsing the endpoint descriptor was inconsistent with the usb device specification. This patch fixed the issue by updating the mask from 0x7 to 0xf and also updated the corresponding UT test cases. If you have time, could you please review this commit? |
a1ien
approved these changes
Dec 29, 2025
Owner
|
Nice catch. Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed a bug in parsing the ndpoint number from the address field in endpoint descriptor. According to the USB device specification, bits 0-3 of the address field in the endpoint descriptor represent the endpoint number. Therefore, when parsing the number from the address, it should be masked with 0xf instead of 0x7. Incorrect parsing will lead to corrupted device endpoint information.