Repository navigation
feat(samples): run the Lit restaurant demo with the Node agent, and load .env in the Node agent - #3417
Open
parvezk wants to merge 3 commits into
Open
feat(samples): run the Lit restaurant demo with the Node agent, and load .env in the Node agent#3417parvezk wants to merge 3 commits into
parvezk wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds support for running the restaurant finder agent using a pure Node.js setup (both live and stub modes) without requiring Python or uv. It updates the documentation, README, and package scripts to support these new run configurations. Feedback on the changes includes a correction to the relative path for the repository root .env file in the Node agent's start command, which is currently off by one directory level.
parvezk
force-pushed
the
feat/lit-node-restaurant-demo
branch
from
October 26, 2026 19:47
311863d to
4115eed
Compare
parvezk
marked this pull request as ready for review
October 26, 2026 19:48
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Lit restaurant demo (
samples/client/lit) only starts the Python ADK agent, so a JS/TS developer who has already runyarn installalso needs Python anduvto try it. The Lit sample predates the Node restaurant agent (samples/agent/node/restaurant_finder, added in #2816), which serves the same A2A endpoint on port 10002 and has aSTUB_LLM=truemode that needs no API key.This PR wires that agent into the Lit demo and fixes
.envloading for it:samples/client/lit/package.json: addsdemo:restaurant:node(Lit shell plus the Node agent against Gemini) anddemo:restaurant:stub(Lit shell plus the Node agent withSTUB_LLM=true), with matchingserve:agent:restaurant:node/serve:agent:restaurant:stubscripts. The existingdemo:restaurantis unchanged.samples/agent/node/restaurant_finder/package.json: the README says tocp .env.example .env, butstartrannode dist/src/index.js, so the.envfile was never read.startnow passes--env-file-if-exists=.env --env-file-if-exists=../../../.env, which picks up the sample's.envor one at the repository root. A variable already exported in the shell still wins.docs/public/quickstart.md: adds a collapsed tip under Step 3 (Lit) for the two new commands.samples/agent/node/restaurant_finder/README.md: documents the.envflow and the new Lit demo commands.--env-file-if-existsneeds Node 22.9 or later. CI already uses Node 22, and the Vite 8 dependency of the Lit shell already rules out Node 18.Testing
yarn workspace @a2ui/agent-restaurant-node test: 5 files, 42 tests pass.GEMINI_API_KEYis read from.envwhen it is not exported.prettier --checkpasses on the changed files.Pre-launch Checklist
One time:
For this PR: