Skip to content

chore(python): remove missing gemini_enterprise workspace members from pyproject.toml - #3418

Open
parvezk wants to merge 3 commits into
a2ui-project:mainfrom
parvezk:fix/pyproject-gemini-enterprise-members
Open

parvezk wants to merge 3 commits into
a2ui-project:mainfrom
parvezk:fix/pyproject-gemini-enterprise-members

Conversation

@parvezk

@parvezk parvezk commented Oct 22, 2026 •

Copy link
Copy Markdown

Description

Removes two workspace members from the root pyproject.toml whose directories no longer exist:

  • samples/community/agent/adk/gemini_enterprise/agent_engine
  • samples/community/agent/adk/gemini_enterprise/cloud_run

#2086 moved both directories under samples/community/agent/adk/gemini_enterprise/v0_8/ but left the root members list unchanged. uv reads each member as a glob, and a glob that matches nothing is skipped silently, so nothing failed. Their packages (a2ui-contactcard-agentengine and a2ui-contact-lookup) were dropped from the root uv.lock at the next relock.

I removed the entries instead of pointing them at v0_8/. With the v0_8/ paths, uv lock --check fails because those legacy samples pull google-cloud-aiplatform[adk,agent-engines] and a pinned a2a-sdk==0.3.25 into the root lockfile. community_code.yml already syncs every samples/community/**/pyproject.toml on its own. Nothing else in the repository references the old paths.

Testing

  • uv lock --check passes (220 packages resolved) and uv.lock is unchanged.

Pre-launch Checklist

One time:

For this PR:

  • I have updated the relevant CHANGELOG.md file.
  • I updated/added relevant documentation.
  • My code changes (if any) have tests.
  • If my branch is on a fork, I have verified that scripts/e2e_test.sh passes.

@google-cla

google-cla Bot commented Oct 22, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates pyproject.toml by removing the gemini_enterprise/agent_engine and gemini_enterprise/cloud_run sample directories from the workspace members list. There are no review comments to evaluate, and no further feedback is required.

@github-actions github-actions Bot added the status: needs-triage auto-managed: https://github.com/a2ui-project/a2ui/blob/main/scripts/triage.mjs label Oct 22, 2026
@parvezk
parvezk force-pushed the fix/pyproject-gemini-enterprise-members branch from 3d09924 to 14c2581 Compare October 26, 2026 20:00
@parvezk
parvezk marked this pull request as ready for review October 26, 2026 20:03
@parvezk
parvezk force-pushed the fix/pyproject-gemini-enterprise-members branch from 14c2581 to dcfa7ba Compare October 26, 2026 20:23

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: needs-triage auto-managed: https://github.com/a2ui-project/a2ui/blob/main/scripts/triage.mjs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant