[gspencergoog]

Summary

Add shared conformance suites for renderer-to-agent error responses and UI adapters, and expand existing suites under conformance/core/. Run the accessibility and adapter suites across @a2ui/lit, @a2ui/react, @a2ui/angular, a2ui_flutter, and A2UISwiftUI.

Reviewer Focus

1. Check conformance/core/adapter_conformance.yaml and conformance/core/accessibility.yaml first. They define the declarative UI expectations that each renderer test runner executes mechanically.
2. Check conformance/core/error_responses.yaml and validate_renderer_error_payload in conformance/tests/test_conformance_yaml.py. Together they check every expected error payload against the published v0.9 and v1.0 wire schemas.
3. Inspect the runtime adapter changes in dart/a2ui_flutter/lib/src/node_view.dart, typescript/renderers/react/src/A2uiSurface.tsx, typescript/renderers/react/src/web_component_node.tsx, and swift/swiftui/Sources/BasicCatalog/.
4. Skim the five adapter_conformance test files (~4,000 lines combined) once the YAML definitions look right. Each runner maps the same step operations (process_messages, user_input, user_gesture, programmatic_invoke, unmount_surface) onto its UI framework.

Changes

1. Extend conformance/conformance_schema.json and conformance/tests/test_conformance_yaml.py with the render_surface action, userActivation flags, and ExpectError fields (path, surfaceId, functionCallId, rendererError).
2. Add conformance/core/error_responses.yaml (23 error cases and 1 non-strict buffered streaming case) and conformance/core/adapter_conformance.yaml (13 UI adapter cases), and update conformance/core/accessibility.yaml to v1.0 schemas. Expand node_resolution.yaml, validation_result.yaml, actions.yaml, rpc_functions.yaml, composition_constraints.yaml, validator_v0_9.yaml, validator_v1_0.yaml, message_processor_v0_9.yaml, and message_processor_v1_0.yaml. Document the new suites and adapter runner contracts in conformance/README.md and conformance/conformance_harness_implementation_guide.md.
3. Update @a2ui/web_core (expression_parser.ts) and swift/core (ExpressionParser.swift) to parse ${@index()}, and update dart/a2ui_core (generic_binder.dart, validation_result.dart) so explicit CheckRule.message overrides function defaults on evaluated checks. Update the conformance runners in @a2ui/web_core (conformance_test.mjs, node-resolution.ts, accessibility_conformance.test.ts), dart/a2ui_core (conformance_harness.dart, message_processor_conformance_test.dart, validator_conformance_test.dart), and swift/core (ConformanceTestHelper.swift, ValidatorConformanceTests.swift).
4. Add conformance tests to @a2ui/lit (a2ui-surface.ts rootNode getter and adapter_conformance.test.ts) and @a2ui/angular (karma.conf.js and adapter_conformance.spec.ts). In @a2ui/react, prepare catalogs on componentsModel.onCreated in A2uiSurface.tsx, dispose detached element controllers and clear _controllerNode in web_component_node.tsx, and add adapter_conformance.test.tsx.
5. Subscribe NodeView in dart/a2ui_flutter/lib/src/node_view.dart to data-bound accessibility signals (label, description, live, hidden) so Flutter semantics update reactively. Add dart/a2ui_flutter/test/adapter_conformance_test.dart.
6. Update A2UISwiftUI basic catalog views in A2UITextField.swift and A2UIButton.swift for warning or info validation captions and requiresUserActivation metadata, while keeping Surface and A2UIAccessibilityModifier unchanged. Add AdapterConformanceTests.swift.

Impact & Risks

1. No breaking API changes. Public surface additions (A2uiSurface.rootNode in @a2ui/lit, ValidationResult.fromEvaluation(explicitMessage:) in a2ui_core, and read-only validation or activation properties on A2UITextField and A2UIButton in A2UISwiftUI) are additive.
2. The core prerequisites (fix(core): coerce ValidationResult to DynamicBoolean arguments from the schema #3653, feat(web_core): add MessageErrorMapper, JSON Pointer error paths, and conformance parity #3579, feat(python-core): add message_error_mapper, NodeResolver, and conformance parity #3580, feat(dart-core): add MessageErrorMapper, validator error details, and conformance parity #3581, feat(swift-core): add MessageErrorMapper envelope handling, JSON Pointer paths, and conformance runners #3582) and consolidated web renderer changes (test(renderers): add UI adapter and accessibility conformance for Lit, React, and Angular #3584) have merged into main. This branch now merges directly onto main.
3. A2UISwiftUITests requires SwiftUI on Apple platforms and runs on macOS CI (swift_build_and_test.yml).

Testing

1. Check conformance YAML schemas and run Python core conformance:

   uv run --directory python/a2ui_core pytest ../../conformance/tests/test_conformance_yaml.py
   uv run --directory python/a2ui_core pytest

2. Run @a2ui/web_core conformance and the adapter tests for the web renderers:

   yarn --cwd typescript/core/web_core test:conformance
   yarn --cwd typescript/renderers/lit test:unit
   yarn --cwd typescript/renderers/react test:unit
   yarn --cwd typescript/renderers/angular test:unit

3. Run Dart core conformance and Flutter adapter tests:

   cd dart/a2ui_core && dart analyze --fatal-infos && dart test
   cd dart/a2ui_flutter && flutter analyze && flutter test

4. Build and run Swift core and SwiftUI conformance suites (SwiftUI tests run on macOS CI):

   swift test --filter A2UIConformanceTests
   swift test --filter A2UISwiftUITests

Review history for consolidated branches: #3584 (web renderers), #3586 (Flutter), #3587 (SwiftUI).

_{🤖 Agent-generated}

[gemini-code-assist]

Code Review

This pull request significantly expands the A2UI conformance test suite by introducing new test files (adapter_conformance.yaml and error_responses.yaml), updating existing test cases to support v1.0 features, and refining the conformance schema. It also updates the Python test runner to validate renderer error payloads against JSON schemas, and updates the Dart and Swift test harnesses to execute the new test suites. Feedback on the Swift test harness identifies a bug in effectiveLabel(for:) where an empty accessibility label string fails to fall back to the child's text.

[nan-yu]

Reviewed PR #3583 (ef0f8e5f). See inline comments for high and medium severity findings.

_{🤖 Agent-generated}

[nan-yu]

[MEDIUM] SwiftUI accessibility conformance assertions bypass A2UISwiftUI views and use hardcoded Node helpers

assertAccessibilityNodes (lines 224–283) and assertAccessibilityTreeMatches (lines 978–1000) in AdapterConformanceTests.swift do not instantiate or inspect A2UISwiftUI views (Surface, ComponentNodeView, A2UIButton, A2UITextField, A2UICheckBox, A2UIChoicePicker). Instead, the test runner computes roles, checked states, and fallback labels directly from A2UICore.Node in test helpers:

• semanticRole(for:) (lines 298–312) is a hardcoded switch node.type table in the test file.
• checkedState(for:) (lines 314–317) reads node.bool(for: "value") directly from the Node.
• effectiveLabel(for:modifier:) (lines 285–296) re-implements label fallback resolution in test code (node.accessibilityAttributes?.label and node.child(for: "child")), bypassing .a2uiAccessibilityControl(for: node, defaultLabel: labelText) used by A2UITextField, A2UICheckBox, and A2UIChoicePicker.

_{🤖 Agent-generated}

[gspencergoog]

SwiftUI has no runtime accessibility tree that a unit test can read without a view inspection dependency, so these helpers mirror the label, role, and checked-state rules the A2UISwiftUI views apply through a2uiAccessibilityControl. The earlier revision exposed them on A2UIAccessibilityModifier and review asked for that public surface to go. If you would rather not have mirrored logic in the test, the alternative is to record the accessibility cases as expected failures for SwiftUI; let me know which you prefer.

_{🤖 Agent-generated}