Repository navigation
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces new conformance test cases for the Express compiler and decompiler, specifically focusing on handling userMessage arguments on events, keyword/positional context arguments, and function calls nested inside list item action slots. It also adds two new test catalog files (list_item_action_catalog_v09.json and list_item_action_catalog_v1_0.json) to support these tests. There are no review comments, so no feedback is provided.
ditman
force-pushed
the
test/express-action-conformance
branch
from
October 26, 2026 20:32
cd71097 to
cc95c1a
Compare
This was referenced Oct 26, 2026
ditman
added a commit
to ditman/a2ui-project-a2ui
that referenced
this pull request
Oct 26, 2026
dorny/paths-filter reads a pull request's files from the GitHub API whenever it has a token, and its `token` input defaults to `github.token`. A transient API error then fails the change-detection job, and with it every job that depends on it, on a pull request that changed nothing relevant. Pass an empty token in the three workflows that use the action, so a pull request is read as `git diff pull_request.base.sha..HEAD`, where HEAD is the pull request's merge commit. The action fetches the base commit itself at depth 1, so the shallow checkouts stay as they are. Push and scheduled runs never used the API and are unchanged. The file sets are the same: the merge commit's first parent is `base.sha`, so the diff is the pull request's changes against the base. Checked on a2ui-project#3633, a2ui-project#3634 and a2ui-project#3637: `git diff merge^1..merge` lists exactly the files `GET /pulls/N/files` returns. The filters use no status qualifiers, so the A/M/D statuses git reports cannot change a result either.
6 of 8 tasks
ditman
force-pushed
the
test/express-action-conformance
branch
from
October 26, 2026 21:38
cc95c1a to
508a06b
Compare
ditman
marked this pull request as ready for review
October 26, 2026 21:40
ditman
force-pushed
the
test/express-action-conformance
branch
from
October 27, 2026 01:35
508a06b to
445a45e
Compare
ditman
force-pushed
the
test/express-action-conformance
branch
from
October 28, 2026 00:31
445a45e to
3098b65
Compare
…slots Add compile and decompile cases for the two Express gaps reported in #3598: - `Event(name, context?, userMessage=?, context=?)`: `userMessage` compiles to the v1.0 `event.userMessage` field (string or `$path`), `context=` is accepted by keyword, an unknown keyword or a duplicate context is a validation error, and `userMessage` before v1.0 is a validation error. - A function call in an action slot nested inside a list item compiles to a `functionCall` action, also when the item is reached through a variable. - The decompiler writes `userMessage=` back and nested action slots round-trip. New catalogs `list_item_action_catalog_v1_0.json` and `list_item_action_catalog_v09.json` declare a `Links` component whose `items[].action` is the common `Action` type.
Action.event.userMessage is a DynamicString, so a function call compiles and round-trips, and a map literal is a validation error.
ditman
force-pushed
the
test/express-action-conformance
branch
from
October 28, 2026 01:13
3098b65 to
bb41082
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shared conformance cases for the two Express gaps in #3598, so the TS, Python and Dart fixes in this stack are held to the same behavior.
Additionally, in
list_item_action_catalog_v1_0.jsonandlist_item_action_catalog_v09.json: aLinkscomponent whoseitems[].actionandprimaryare the commonAction, plusopenUrl. The v0.9 one declaresprotocolVersion: "0.9"explicitly: the Python and Dart harnesses load an undeclared catalog as v1.0, TS as v0.9.Validated with
conformance/tests/test_conformance_yaml.py. Passes in all three SDKs on the branches below it in the stack.Pre-launch Checklist
One time:
For this PR:
If you need help, consider asking for advice on the discussion board.
Stack created with GitHub Stacks CLI • Give Feedback 💬