Repository navigation
优化二级菜单和响应式侧栏,保留原路由与工作流草稿 - #105
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 634fed50c8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
原侧栏将 26 项功能全部平铺,查找和窄屏操作较困难。本次按方案将质量总览与六个可折叠分类组成 7 个一级入口,保留全部 section、页面名称、href 与管理员/普通用户的 26/24 项可见性。
侧栏支持 224/72px、受控单分类展开、键盘浮层、窄屏 Drawer 与关闭后焦点恢复,偏好按用户隔离。总览初次加载恢复合法已存展开偏好,具体页面的分类优先于缓存。两种 Menu 模式各自管理 popup 生命周期,避免模式切换后的关闭事件清掉刚恢复的分类。分类操作不改变 URL/query/hash、工作台 Tab 或编辑器实例;全局管理页选择项目直接进入项目总览,业务页保留原 section。
containerd 构建在 vendoring 前补齐既有 Go 模块图的校验信息,保留原 commit、Go 与 gRPC 版本声明。没有后端业务、数据库或编辑器业务重构。
验证:前端 format/lint/build 通过,88 个文件 421 个测试通过,分支覆盖率 80.74%;后端 Ruff/mypy 通过、1449 passed/7 skipped、覆盖率 90.68%。独立 Compose 中最终 7 个导航专项及 Setup 全部通过(8 passed),含 320px 顶栏、低高度独立菜单滚动;工作流交互/几何回归此前 16 passed(包含导航专项及 Setup)。后续隔离 Linux Chromium 与 Celery worker 覆盖三种分辨率的九种编辑/执行/历史状态,基线生成后关闭更新模式重复比较,每轮 4 passed。18 张菜单外观基线人工核对后更新,原像素阈值、mask、几何/溢出检查保留;旧 V1 主路径点击统一使用分类 helper。定向 containerd 镜像构建与三个 binary 的 gRPC v1.83.2 校验通过。等待最新提交的完整 GitHub 门禁。
最终 Linux 导航与完整工作流交互合跑
pnpm exec playwright test e2e/grouped-navigation.spec.ts e2e/workflow-editor-interactions.spec.ts --project=chromium:16 passed(58.8s),包含认证、7 项导航与8 项交互,未排除真实发布/执行案例。独立测试服务和数据卷已清理,原本地服务及未提交修改保留。docs/NAVIGATION_GROUPING.md提供 26 项旧→新映射、修改清单、状态/权限边界、实际检查命令及 1366/1440/1920/390px 截图。