Repository navigation
V4 阶段性交付：合并现有成果并保留未达标指标 - #7
Conversation
Add V3 capability negotiation, structured media status, reconnect improvements, updated Sony and iOS experiences, expanded tests, localization, architecture docs, and FlowTest artifacts.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8062b63c22
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| val sampled = monoMs ?: clock() | ||
| val stableMonoMs = maxOf(sampled, lastMonoMs) | ||
| lastMonoMs = stableMonoMs |
There was a problem hiding this comment.
When a timestamp captured earlier is recorded after another thread has appended a newer event—for example, BleNotifyQueue captures job.enqueuedAtMs before posting to its queue—this clamp replaces the real timestamp with lastMonoMs. That can reduce measured queue and phase latency to zero and prevents the report from detecting genuine out-of-order events, corrupting the V4 SLO results; the iOS buffer mirrors this behavior in BLEObservableStateModels.swift:1018. Keep the supplied timestamp unchanged and use sequence solely for append order.
Useful? React with 👍 / 👎.
| commands.playPause() | ||
| } | ||
|
|
||
| override fun onPause() { | ||
| commands.playPause() |
There was a problem hiding this comment.
When a headset, system UI, or other media controller sends an explicit onPlay while playback is already active, this forwards PLAY_PAUSE, whose Sony handler toggles the current state, so the request pauses instead; repeated onPause similarly resumes an already paused track. Gate the toggle on the repository's current playback state or add explicit play and pause protocol commands.
Useful? React with 👍 / 👎.
| return (state.positionMs + nowElapsedMs - state.receivedAtElapsedMs) | ||
| .coerceIn(0L, state.durationMs.coerceAtLeast(0L)) |
There was a problem hiding this comment.
For tracks whose media session omits duration, the Sony side intentionally sends duration = 0 while still providing a valid playback position. In that case the upper bound here becomes zero, so every playing position is clamped to 0; the controller's progress display and local lyric timeline remain at the beginning for the entire track. Only apply the upper bound when durationMs > 0, as the Sony runtime clock policy already does.
Useful? React with 👍 / 👎.
合并后验证与额外未闭环项（2026-09-05）已普通合并到 master：02633d18cffa4b7a80e636f9a6f81feacba966bd。父提交为旧 master bc7d4bb 与源分支 8062b63，全部历史保留；主干文件树与已测试源分支完全一致。
新发现的 CI 稳定性待办：未解决源分支与 master 的 iOS 首轮都在 testLastNowPlayingSnapshotStoreSaveLoadAndClear 失败（54 项中 1 项失败），现有工作流重启模拟器并重试一次后均为 54/54 PASS。源分支首轮断言在 PerformanceStabilityTests.swift:782，load 得到 nil 而预期为已保存快照。尚未定位根因，不能将其直接归咎于模拟器或宣称修复；最终绿色不代表首轮稳定通过。后续应独立复现并修复快照存储/测试同步问题，不以增加重试掩盖。 切歌、当前歌词、首字覆盖、冷 Preview/HQ、Sony Bluetooth 两小时稳定性、lint 历史问题及延期能力继续保持原状态，详见 https://github.com/a3384379/MusicBleController/blob/master/docs/V4_ACCEPTANCE_STATUS.md 。合并决定不等于 V4 全量验收完成。 未切换或重新安装设备应用；本地 4 个未提交 tools/deploy 文件保持原状，未包含在此合并中。 |
1 participant
合并决定
维护者明确授权提前将现有 V4 成果合并 master，不等待原性能标准全部达标。此 PR 是阶段性交付，不代表第四阶段完成，不创建正式发布标签。
变更范围
保留现有分支全部提交历史，包括 iOS/Sony 产品 UI、Trace/SLO、精确歌词缓存校验、切歌及 CurrentWord 优化和已回退实验记录。使用普通 merge commit，不 squash、不 rebase、不 force push。
新增 docs/V4_ACCEPTANCE_STATUS.md，README 双语入口，并补上 master push CI。
未达标与延期
验证
应用代码 8c55cd4 的 CI 全绿：https://github.com/a3384379/MusicBleController/actions/runs/33938041361
iOS quick Required 6/6、Sony quick Required 8/8；Sony unit/assemble PASS；报告脚本 29 tests PASS。完整限制及缺样见验收文档。新提交只改文档及 CI 触发，PR 和合并后 master CI 分别复核。
工作区另有 4 个未提交部署文件，本 PR 不包含这些本地改动。其他开放 PR 不在本次操作范围。