redesign experience section with compact card layout - #31
Conversation
📝 WalkthroughWalkthroughThis PR refactors the portfolio's design system and Experience section: new color tokens (terracotta, ink-deep, paper variants) and shadow presets are added to Tailwind and CSS; the SectionDivider component and paper-grain utility are removed; and the Experience component is refactored with Framer Motion viewport animations, grid-based point lists, and a right-column tech stack layout. ChangesDesign System and Experience Component Refactor
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai full review |
✅ Actions performedFull review triggered. |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
tailwind.config.ts (1)
73-77: 💤 Low valueConsider using CSS variables for shadow values.
The shadow definitions use hardcoded
rgbavalues, while the color tokens use CSS variables. This makes the shadows less flexible for theming. You could define--shadow-card-colorand--shadow-card-hover-coloringlobals.cssfor consistency, though the current approach works fine.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@tailwind.config.ts` around lines 73 - 77, Replace the hardcoded rgba values in the tailwind config's boxShadow entries (boxShadow.card and boxShadow["card-hover"]) with CSS variables (e.g. var(--shadow-card-color) and var(--shadow-card-hover-color)) and update the shadow strings to use those variables so themes can override them; also add corresponding CSS variable definitions (e.g. --shadow-card-color, --shadow-card-hover-color) in your global stylesheet so the values can be themed consistently across the app.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@tailwind.config.ts`:
- Around line 73-77: Replace the hardcoded rgba values in the tailwind config's
boxShadow entries (boxShadow.card and boxShadow["card-hover"]) with CSS
variables (e.g. var(--shadow-card-color) and var(--shadow-card-hover-color)) and
update the shadow strings to use those variables so themes can override them;
also add corresponding CSS variable definitions (e.g. --shadow-card-color,
--shadow-card-hover-color) in your global stylesheet so the values can be themed
consistently across the app.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 2a0199c8-c035-4ca0-a7f7-222e26ec4f62
📒 Files selected for processing (5)
src/app/globals.csssrc/app/page.tsxsrc/components/Experience.tsxsrc/components/SectionDivider.tsxtailwind.config.ts
💤 Files with no reviewable changes (1)
- src/components/SectionDivider.tsx
Summary by CodeRabbit