Skip to content

Single install command#1

Open
krisl wants to merge 10 commits into
aaron-riact:masterfrom
krisl:single-install-command
Open

Single install command#1
krisl wants to merge 10 commits into
aaron-riact:masterfrom
krisl:single-install-command

Conversation

@krisl
Copy link
Copy Markdown

@krisl krisl commented Aug 22, 2025

No description provided.

@aaron-riact aaron-riact requested review from Copilot and removed request for Copilot August 22, 2025 18:03
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a "single install command" feature that allows package installers to use a single invocation to install multiple packages instead of running separate commands for each package. The change is controlled by a new --one-shot command line option that accepts installer names like "apt" or "pip".

Key changes:

  • Adds --one-shot command line option to enable single-command installation for specified installers
  • Modifies installer interfaces to support the oneshot parameter
  • Updates both apt and pip installers to combine multiple packages into single install commands when oneshot is enabled

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/rosdep2/main.py Adds --one-shot command line option and passes it through to installation logic
src/rosdep2/installers.py Updates installer base classes and installation flow to support oneshot parameter
src/rosdep2/platforms/debian.py Implements oneshot support for apt installer, combining packages into single command
src/rosdep2/platforms/pip.py Implements oneshot support for pip installer, combining packages into single command
test/test_rosdep_main.py Adds test case for --one-shot functionality with apt installer
test/test_rosdep_pip.py Adds test cases for oneshot functionality in pip installer
test/test_rosdep_debian.py Adds test cases for oneshot functionality in debian/apt installer and removes debug print
test/test_rosdep_installers.py Updates test expectations to match new single-command output format

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread test/test_rosdep_debian.py Outdated
Comment thread src/rosdep2/platforms/debian.py Outdated
@krisl krisl force-pushed the single-install-command branch from 3162a95 to d090ab1 Compare August 23, 2025 14:58
@krisl krisl force-pushed the single-install-command branch from d090ab1 to 0744713 Compare August 23, 2025 15:01
@krisl krisl force-pushed the single-install-command branch from 0744713 to 2520aef Compare August 24, 2025 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants