Single install command#1
Open
krisl wants to merge 10 commits into
Open
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a "single install command" feature that allows package installers to use a single invocation to install multiple packages instead of running separate commands for each package. The change is controlled by a new --one-shot command line option that accepts installer names like "apt" or "pip".
Key changes:
- Adds
--one-shotcommand line option to enable single-command installation for specified installers - Modifies installer interfaces to support the oneshot parameter
- Updates both apt and pip installers to combine multiple packages into single install commands when oneshot is enabled
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/rosdep2/main.py | Adds --one-shot command line option and passes it through to installation logic |
| src/rosdep2/installers.py | Updates installer base classes and installation flow to support oneshot parameter |
| src/rosdep2/platforms/debian.py | Implements oneshot support for apt installer, combining packages into single command |
| src/rosdep2/platforms/pip.py | Implements oneshot support for pip installer, combining packages into single command |
| test/test_rosdep_main.py | Adds test case for --one-shot functionality with apt installer |
| test/test_rosdep_pip.py | Adds test cases for oneshot functionality in pip installer |
| test/test_rosdep_debian.py | Adds test cases for oneshot functionality in debian/apt installer and removes debug print |
| test/test_rosdep_installers.py | Updates test expectations to match new single-command output format |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
3162a95 to
d090ab1
Compare
d090ab1 to
0744713
Compare
This should make the installation faster.
0744713 to
2520aef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.