Skip to content

Support reinstall in check command#2

Open
krisl wants to merge 17 commits into
aaron-riact:masterfrom
krisl:support-reinstall-in-check-command
Open

Support reinstall in check command#2
krisl wants to merge 17 commits into
aaron-riact:masterfrom
krisl:support-reinstall-in-check-command

Conversation

@krisl
Copy link
Copy Markdown

@krisl krisl commented Aug 22, 2025

No description provided.

@aaron-riact aaron-riact requested a review from Copilot August 22, 2025 18:03
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the rosdep codebase to support the --reinstall option in the check command by extracting common dependency resolution logic into a shared function. The main changes involve separating dependency resolution from installation checking and modifying the RosdepInstaller class to work with pre-resolved dependencies.

  • Extracts dependency resolution logic into a shared _resolve_dependencies function
  • Modifies RosdepInstaller to accept pre-resolved dependencies instead of performing resolution internally
  • Updates the dependency resolution algorithm in RosdepLookup.resolve_all to use a flattened approach

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
src/rosdep2/main.py Extracts _resolve_dependencies function and refactors command_check and command_install to use shared logic
src/rosdep2/installers.py Removes lookup dependency from RosdepInstaller constructor and modifies get_uninstalled to accept pre-resolved dependencies
src/rosdep2/lookup.py Refactors dependency resolution algorithm to use a flattened queue-based approach
test/test_rosdep_installers.py Updates tests to reflect the new RosdepInstaller API changes

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread src/rosdep2/lookup.py
Comment thread src/rosdep2/main.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants