Support reinstall in check command#2
Open
krisl wants to merge 17 commits into
Open
Conversation
This reverts commit 1aa399ccba49a8d7f43a5f267c990a5cae17a1f8.
This reverts commit 12ab29b28fef5564399cf3120ace9c91e377b649.
This reverts commit 545748c588214666aa039a0f5bfae15b4a43dbdb.
make check command report like install
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the rosdep codebase to support the --reinstall option in the check command by extracting common dependency resolution logic into a shared function. The main changes involve separating dependency resolution from installation checking and modifying the RosdepInstaller class to work with pre-resolved dependencies.
- Extracts dependency resolution logic into a shared
_resolve_dependenciesfunction - Modifies
RosdepInstallerto accept pre-resolved dependencies instead of performing resolution internally - Updates the dependency resolution algorithm in
RosdepLookup.resolve_allto use a flattened approach
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/rosdep2/main.py | Extracts _resolve_dependencies function and refactors command_check and command_install to use shared logic |
| src/rosdep2/installers.py | Removes lookup dependency from RosdepInstaller constructor and modifies get_uninstalled to accept pre-resolved dependencies |
| src/rosdep2/lookup.py | Refactors dependency resolution algorithm to use a flattened queue-based approach |
| test/test_rosdep_installers.py | Updates tests to reflect the new RosdepInstaller API changes |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.