Add additional context to send_email_with_callback_token template and plaintext#46
Open
firstTimeCaller wants to merge 3 commits intoaaronn:masterfrom
Open
Add additional context to send_email_with_callback_token template and plaintext#46firstTimeCaller wants to merge 3 commits intoaaronn:masterfrom
firstTimeCaller wants to merge 3 commits intoaaronn:masterfrom
Conversation
Contributor
|
a solution here should be generalizable to other use cases. your email link format for example, is unlikely to be usable by others. another approach is to extend the context processing scaffold in |
Author
|
JWS, your suggestion is so much more elegant! I can't believe I didn't see the simpler solution of passing the user to the template. I will update accordingly. |
ba5645a to
8f5fd09
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Aaronn,
Thank you for the great project.
I am interested in having the emailed token within a URL. This will mean a user will only have to click on the anchor, rather then copying and pasting the token. As the users email is also required for auth_token I have added this in the link.