Feat security#102
Draft
dominikletica wants to merge 247 commits into
Draft
Conversation
Feat security planning
dominikletica
commented
Jun 15, 2026
dominikletica
marked this pull request as ready for review
June 15, 2026 20:13
dominikletica
marked this pull request as draft
June 15, 2026 20:14
Feat security policy docs
dominikletica
commented
Jun 15, 2026
feat-security-captcha-contract
dominikletica
commented
Jun 21, 2026
dominikletica
left a comment
Member
Author
There was a problem hiding this comment.
Progress
feat-security-captcha-contractsplitter, part 1 merged- Feature implementation branch
- Branch split justified by huge rename-diff (packages->extensions)
- Checks passed:
bin/phpunitOK,bin/jstestOK,bin/lintOK - Codex Cloud Review reported 37 issues: 35 resolved, 2 handled as explicit decisions/follow-ups
- Local Review reported 7 additional issues: 7 resolved
- Spark reported 3 additional issues: 2 resolved, 1 rejected as invalid after validation but led to a related hardening fix
dominikletica
commented
Jun 21, 2026
dominikletica
left a comment
Member
Author
There was a problem hiding this comment.
Progress
- Addressed CI test failures
- Checks passed:
bin/phpunit,bin/jstest,bin/lint
…r cleanup behavior
17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is an aggregation PR for the
feat-securitybranch tree and consists of the following child-branches:feat-security-planningfeat-security-policy-docsfeat-security-geoip-observabilityfeat-security-abuse-foundationfeat-security-admin-acl-enforcementfeat-security-rate-enforcementfeat-security-auto-banfeat-security-captcha-contractfeat-security-icon-captchafeat-security-remember-me*)
feat-mailer-account-deliverydeferred to the futurefeat-mailer-branch.Testing
(Note: Will be updated when this PR is marked ready-for-review.)
bin/phpunit: [RESULT]bin/jstest: [RESULT]bin/lint: [RESULT]Progress
Progress will be captured in separate follow-up review comments to this PR. Use those to determine whether or not a change has already been reviewed.
Review Notes
Since merge commits were already reviewed before being merged into this branch, a light follow-up pass is sufficient: focus on obvious code-quality issues, security or privacy regressions, behavior changes, stale planning assumptions, and side/cross effects caused by the combination with other merged changes.
For newly not-yet-reviewed commits (e.g. review fixes or small additions pushed directly to this branch after the last merge commit has landed), perform a normal review and cover code quality, security/privacy considerations, behavioral correctness, tests, documentation consistency, branch boundaries, and worklog accuracy.
No runtime behavior is intended to change inside this aggregation PR aside from changes implemented through PR merges into this branch.