Audit test suite performance#94
Merged
Merged
Conversation
Closed
dominikletica
marked this pull request as ready for review
June 1, 2026 13:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Audited the PHPUnit suite for low-value coverage, accidental test discovery, and state-leak risks. Narrowed discovery to real
*Test.phpfiles, removed.codexhelper-script coverage from the project test suite, trimmed UI/CSS/Stimulus-heavy assertions, consolidated duplicate route-smoke checks, and moved one setup validation case from a browser/controller test to a lighter factory-level test.Also added safer cleanup for ZIP installer integration tests so failed assertions do not leave temporary package directories, upload roots, or package rows behind.
Testing
bin/phpunit: Passed (791 tests,4876 assertions, peak121 MB)bin/linton changed PHP files passedgit diff --checkpassedDocumentation
README.md)dev/draft/*.md)dev/CLASSMAP.md)dev/WORKLOG.md)dev/manual/*.md/docs/*.md).codex/test-suite-performance-audit-2026-06-01.md)Additional Checks
Review Notes
No production behavior changes are intended. Remaining performance hotspots are mostly valuable integration coverage, especially setup/backend flows and the ZIP installer overwrite/dependency scenario. A future package-installer fixture strategy is deferred rather than weakening that coverage in this PR.