Skip to content

Audit test suite performance#94

Merged
dominikletica merged 10 commits into
dev-latestfrom
audit-test-suite-performance
Jun 1, 2026
Merged

Audit test suite performance#94
dominikletica merged 10 commits into
dev-latestfrom
audit-test-suite-performance

Conversation

@dominikletica

Copy link
Copy Markdown
Member

Summary

Audited the PHPUnit suite for low-value coverage, accidental test discovery, and state-leak risks. Narrowed discovery to real *Test.php files, removed .codex helper-script coverage from the project test suite, trimmed UI/CSS/Stimulus-heavy assertions, consolidated duplicate route-smoke checks, and moved one setup validation case from a browser/controller test to a lighter factory-level test.

Also added safer cleanup for ZIP installer integration tests so failed assertions do not leave temporary package directories, upload roots, or package rows behind.

Testing

  • bin/phpunit: Passed (791 tests, 4876 assertions, peak 121 MB)
  • Other: Targeted PHPUnit runs for changed controller/setup/package tests passed
  • Other: bin/lint on changed PHP files passed
  • Other: git diff --check passed

Documentation

  • Updated project readme (README.md)
  • Updated feature drafts (dev/draft/*.md)
  • Updated class map (dev/CLASSMAP.md)
  • Updated worklog (dev/WORKLOG.md)
  • Updated dev/user manuals (dev/manual/*.md / docs/*.md)
  • Updated agent audit notes (.codex/test-suite-performance-audit-2026-06-01.md)

Additional Checks

  • Security/privacy considerations
  • Follow-up tasks captured in WORKLOG
  • Linked issues / discussions
  • Updated / aligned translations

Review Notes

No production behavior changes are intended. Remaining performance hotspots are mostly valuable integration coverage, especially setup/backend flows and the ZIP installer overwrite/dependency scenario. A future package-installer fixture strategy is deferred rather than weakening that coverage in this PR.

@dominikletica dominikletica self-assigned this Jun 1, 2026
@dominikletica dominikletica added the performance Something affects performance and should be reviewed immediately label Jun 1, 2026
@dominikletica dominikletica linked an issue Jun 1, 2026 that may be closed by this pull request
@dominikletica
dominikletica marked this pull request as ready for review June 1, 2026 13:38
@dominikletica
dominikletica merged commit c84a192 into dev-latest Jun 1, 2026
1 check passed
@dominikletica
dominikletica deleted the audit-test-suite-performance branch June 1, 2026 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

performance Something affects performance and should be reviewed immediately

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Audit Unit-Test-Suite

1 participant