Audit project readiness#97
Merged
Merged
Conversation
dominikletica
commented
Jun 6, 2026
Member
Author
There was a problem hiding this comment.
Huge refactor, but only one failed test:
App\Tests\Security\SessionVisitorBindingSubscriberTest::testItKeepsSessionsWhenTheBoundVisitorMatches
Failed asserting that true is false.
/Users/letica/Library/Mobile Documents/com~apple~CloudDocs/Repository/studio/tests/Security/SessionVisitorBindingSubscriberTest.php:107
/Users/letica/Library/Mobile Documents/com~apple~CloudDocs/Repository/studio/vendor/phpunit/phpunit/phpunit:104
Nice so far. Needs to be addressed before review-readiness, though.
PS: Here's a second one from the Windows compatibility check CI:
App\Tests\Core\Console\ConsoleResultRendererTest::testItWritesIssuesAndMessagesAndReturnsFailure
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
#Warning: Strings contain different line endings!
-'[WARN] message.workflow.issue
-[INFO] message.workflow.message
+'[WARN] message.workflow.issue
+[INFO] message.workflow.message
'
D:\a\studio\studio\tests\Core\Console\ConsoleResultRendererTest.php:37
D:\a\studio\studio\vendor\phpunit\phpunit\phpunit:104
dominikletica
commented
Jun 6, 2026
dominikletica
left a comment
Member
Author
There was a problem hiding this comment.
Ready for review.
dominikletica
marked this pull request as ready for review
June 6, 2026 18:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Huge audit and refactoring PR addressing #57 at a broader scale to identify and address project rule drift in the early stages up to now. A focussed version of this drift-audit will be part of every PR-readiness-check in the future.
Testing
bin/phpunit: OK (997 tests, 6877 assertions)bin/lint,php bin/console lint:container, andgit diff --checkexcluding Markdown files passed locallyDocumentation
README.md)dev/draft/*.md)dev/CLASSMAP.md)dev/WORKLOG.md)dev/manual/*.md/docs/*.md)Additional Checks
Review Notes
Timeline Notice
The next full-scale (whole project) audit is scheduled as closure for the 0.5.0 dev-preview release-milestone.