Skip to content

Audit project readiness#97

Merged
dominikletica merged 117 commits into
dev-latestfrom
audit-project-readiness
Jun 6, 2026
Merged

Audit project readiness#97
dominikletica merged 117 commits into
dev-latestfrom
audit-project-readiness

Conversation

@dominikletica

@dominikletica dominikletica commented Jun 5, 2026

Copy link
Copy Markdown
Member

Summary

Huge audit and refactoring PR addressing #57 at a broader scale to identify and address project rule drift in the early stages up to now. A focussed version of this drift-audit will be part of every PR-readiness-check in the future.

Testing

  • bin/phpunit: OK (997 tests, 6877 assertions)
  • Other (describe): Focused PHPUnit coverage for package validation and APP_SECRET rotation recovery, bin/lint, php bin/console lint:container, and git diff --check excluding Markdown files passed locally

Documentation

  • Updated project readme (README.md)
  • Updated feature drafts (dev/draft/*.md)
  • Updated class map (dev/CLASSMAP.md)
  • Updated worklog (dev/WORKLOG.md)
  • Updated dev/user manuals (dev/manual/*.md / docs/*.md)

Additional Checks

Review Notes

Timeline Notice

The next full-scale (whole project) audit is scheduled as closure for the 0.5.0 dev-preview release-milestone.

@dominikletica dominikletica self-assigned this Jun 5, 2026
@dominikletica dominikletica added the question Further information is requested label Jun 5, 2026

@dominikletica dominikletica left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huge refactor, but only one failed test:

App\Tests\Security\SessionVisitorBindingSubscriberTest::testItKeepsSessionsWhenTheBoundVisitorMatches
Failed asserting that true is false.

/Users/letica/Library/Mobile Documents/com~apple~CloudDocs/Repository/studio/tests/Security/SessionVisitorBindingSubscriberTest.php:107
/Users/letica/Library/Mobile Documents/com~apple~CloudDocs/Repository/studio/vendor/phpunit/phpunit/phpunit:104

Nice so far. Needs to be addressed before review-readiness, though.

PS: Here's a second one from the Windows compatibility check CI:

App\Tests\Core\Console\ConsoleResultRendererTest::testItWritesIssuesAndMessagesAndReturnsFailure
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
 #Warning: Strings contain different line endings!
-'[WARN] message.workflow.issue
-[INFO] message.workflow.message
+'[WARN] message.workflow.issue
+[INFO] message.workflow.message
 '

D:\a\studio\studio\tests\Core\Console\ConsoleResultRendererTest.php:37
D:\a\studio\studio\vendor\phpunit\phpunit\phpunit:104

@dominikletica dominikletica left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready for review.

@dominikletica
dominikletica marked this pull request as ready for review June 6, 2026 18:53
@dominikletica
dominikletica merged commit 64d71b1 into dev-latest Jun 6, 2026
4 checks passed
@dominikletica
dominikletica deleted the audit-project-readiness branch June 6, 2026 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

question Further information is requested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

P4 drift audit: architecture, modularity, naming, performance, and Symfony alignment

1 participant