Feat api#98
Conversation
dominikletica
left a comment
dominikletica
left a comment
There was a problem hiding this comment.
Foundation OK (1055 tests, 7250 assertions), Audit pending
dominikletica
left a comment
dominikletica
left a comment
There was a problem hiding this comment.
Pass.
Test-Suite OK (1121 tests, 7768 assertions)
Ready for review.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c54c2fc1ca
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
dominikletica
left a comment
dominikletica
left a comment
There was a problem hiding this comment.
OK (1124 tests, 7804 assertions)
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3c617a6596
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
dominikletica
left a comment
dominikletica
left a comment
There was a problem hiding this comment.
Resolved review findings
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 820c381bee
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
dominikletica
left a comment
dominikletica
left a comment
There was a problem hiding this comment.
Addressed review findings.
php bin/phpunit: OK, 1130 tests, 7819 assertions
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3fb9dbed25
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
dominikletica
left a comment
dominikletica
left a comment
There was a problem hiding this comment.
Addressed review findings.
bin/phpunit: OK, 1138 Tests, 7851 assertions
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e9b23bef06
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
dominikletica
left a comment
dominikletica
left a comment
There was a problem hiding this comment.
Addressed review findings.
php bin/phpunit: OK, 1143 tests, 7870 assertions
1 participant
Summary
Added the
feat-apifoundation and first functional API slices for Studio: stateless/api/v1API-key authentication, public-read opt-ins, read-only/read-write method gating, centralized endpoint definition/handler registration, dynamic OpenAPI 3.2 generation, root/navigation resources, admin/user/package/content/schema baseline endpoints, settings/user/admin mutations where the domain layer already supports them, deterministic API availability/error handling, CORS settings, trace headers, JSON content-type enforcement, standardizedpage/limitlist contracts, and an admin endpoint permissions matrix.The branch keeps API execution in the owning user context so existing domain ACL logic remains authoritative, and prepares package/domain endpoint registration without exposing arbitrary routes or Doctrine/DBAL access through the API layer.
Testing
bin/phpunit: OK (1121 tests, 7768 assertions)php bin/console lint:container: passed.bin/lint: passed.git diff --check: passed.Documentation
README.md)dev/draft/*.md)dev/CLASSMAP.md)dev/WORKLOG.md)dev/manual/*.md/docs/*.md)Additional Checks
Review Notes
The API branch is intended as a feature-complete foundation for the current domain state, not as the final content/editor API contract. Content write endpoints are deliberately stable
501stubs until the Editor/Content model exposes final command services.Known non-blocking follow-ups are documented: package API handlers should get a controlled safe handler/context model before public package API release, and several larger API handlers should be split by read/command responsibility when their next real behavior is added.