Skip to content

abacchi00/dropull-challenge

Repository files navigation

App created to complete Dropull's Coding Challenge

---> Demo website <---

💻 Instructions on how to run the project

  • Install yarn
  • Clone the project
  • Run yarn to install dependencies
  • Run yarn dev and access localhost:3000 to test the project
  • Run yarn test to run tests

☑️ What was done

Acceptance Criteria (Must Have)

  • ✔️ Use of React and Next.js
  • ✔️ Does it run as expected: Does the step-by-step required to run the application work?
  • ✔️ Code organization: Module separation and project organization
  • ✔️ Documentation of your process:
    • ✔️ Instructions on how to run the project (e.g. README.md, DEVELOPERLOG.md)
    • ✔️ What was done
    • ✔️ What could be improved
  • ✔️ Pages must be fully responsive and mobile friendly
  • ➖ Unit tests - no need to achieve 100% coverage, but rather cover some components to showcase your test writing skills
    Notes: I don't know if they are enough, but surely I would like to write more (and better) tests
  • ✔️ Good markup, semantic HTML and SEO concerns
    Notes: It is up to the evaluator if it has a good Markup and SEO concerns

Optional Criteria (Nice to Have)

  • ✔️ Use of CSS-in-JS
    Notes: with Emotion library
  • ✔️ Use of TypeScript
  • ✖️ Use of Storybook
  • ✔️ Loading transitions between pages
  • ✖️ Accessibility concerns
  • ✔️ A demo website running on Vercel, Netlify or any other similar free platform
  • ✔️ It doesn't have to be pixel perfect but follow the layout
  • ✔️ Use theme with design tokens
    Notes: Got to improve it but yes
  • ✖️ Use a internationalization framework (e.g. i18next)

🙈 What could be improved

  • Evaluate if using Next.js's server side props would be a better option to get data
  • Add more unit tests
  • Add more tokens to theme in order to standardize project's design
  • Implement integration tests
  • Configure test coverage
  • Congigure CI and branch permissions (such as testing when mergin to main and blocking main merges that are not from PR's)
  • Configure ESLint
  • Add i18n (English and Portuguese)
  • Check referrer in order to block accessing purchase page via url typing
  • Better use of Next.js's Image component
  • Better decoupling from project's mocks

About

Next.js app created to complete Dropull's Coding Challenge :)

Topics

Resources

Stars

Watchers

Forks

Releases

No releases published

Packages

No packages published