Overview: library per control; strip the source-map comment from the vendored libraries - #15
Merged
oblomov-dev merged 2 commits intoAug 10, 2026
Conversation
Six of the vendored bundles end in `//# sourceMappingURL=<name>.map`. The .map files are developer tooling and are not vendored, so on the `local` branch that pointer resolves to a BSP page that does not exist: any browser with devtools open requests it and gets a 404 next to a custom control - the exact symptom someone would spend an afternoon chasing on an offline system. The pointer is dropped when vendoring, and a check afterwards fails the build if a library spells one some other way. Nothing is lost: without a map the debugger shows the shipped file. Found while auditing what the local branch still reaches for. The rest came back clean - the libraries carry no absolute URL they load from, the stylesheets have no @import and no url() beyond the inlined fonts, and none of them opens an XHR, a fetch or a script tag. The README now says so, and also names the one thing that is genuinely still external and lives outside this repository: the UI5 bootstrap, which abap2UI5 takes from sdk.openui5.org unless cs_config-src points somewhere local. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HJz2xJiGdXe7fGyVrtFFzA
Two changes to z2ui5_cl_cci_sample_00. A `Library` column, because the question the overview could not answer was the one that decides whether a control works at all on a given system: what does it pull in from outside. Three kinds of answer - `none` for the self-contained controls, `... from UI5` for what the UI5 distribution already carries, and the library's name for the rest, which is loaded from jsDelivr on `main` and from this BSP on the `local` branch. Without version numbers on purpose: they are pinned in package.json and would rot here on the next bump with nothing to catch it. And the CodeEditor row is gone. It launched Z2UI5_CL_CCI_SAMPLE_10, the very same app the Markdown row launches, because CodeEditor has no demo of its own - it is the editor on the left of the Markdown one. The list is one row per demo now, which is what the buttons actually do. The control itself is untouched and still documented in the README. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HJz2xJiGdXe7fGyVrtFFzA
oblomov-dev
deleted the
claude/custom-controls-batches-libraries-vqtvpj
branch
August 10, 2026 18:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two independent commits.
1. Strip the source-map comment from the vendored libraries
Six of the vendored bundles ended in
//# sourceMappingURL=<name>.map. The.mapfiles are developer tooling and are not vendored, so on thelocalbranch that pointer resolves to a BSP page that does not exist: any browser with devtools open requests it and gets a 404 next to a custom control — the exact symptom someone would spend an afternoon chasing on an offline system. The pointer is now dropped when vendoring, and a check afterwards fails the build if a library spells one some other way. Nothing is lost — without a map the debugger shows the shipped file.This came out of an audit of what the
localbranch still reaches for. The rest came back clean, and the README now records it:xmlns(a namespace, not a fetch), a Markdown demo link, the barcode example textapp/webapp/cc/*.jsLibUrlsindex.html@import, nourl()beyond the inlined fontshttphits are banner comments and marked's autolink prefix, not load addressesfetch, a worker or a script tagThe one thing that genuinely remains external lives outside this repository and is now named in the README: abap2UI5 bootstraps UI5 from
https://sdk.openui5.org/...unlesscs_config-srcpoints at a local distribution. That is also wheresap.ui.exportandsap.ui.codeeditorcome from.2. Overview: a Library column, and one row per demo
z2ui5_cl_cci_sample_00gains a Library column, because the question it could not answer was the one that decides whether a control works on a given system: what does it pull in from outside. Three kinds of answer —nonefor the self-contained controls,… from UI5for what the distribution already carries, and the library's name for the rest (jsDelivr onmain, this BSP onlocal). Deliberately without version numbers: those are pinned inpackage.jsonand would rot in ABAP on the next bump with nothing to catch it.The CodeEditor row is gone. It launched
Z2UI5_CL_CCI_SAMPLE_10— the same app the Markdown row launches — because CodeEditor has no demo of its own; it is the editor on the left of the Markdown one. The list is one row per demo now, which is what the buttons actually do. The control itself is untouched and still documented in the README.Column widths were retuned for the fifth column (fixed columns now add up to 49rem, description stays flexible, Library folds into the popin from tablet down).
Verified
npm run lint0 issues (69 files),npm test9/9,app2bspandvendorin sync, local build rebuilt and free ofsourceMappingURL, all vendored JS still passesnode --check.🤖 Generated with Claude Code
https://claude.ai/code/session_01HJz2xJiGdXe7fGyVrtFFzA
Generated by Claude Code