Migrate from z2ui5_cl_ai_xml to z2ui5_cl_ui5_view_builder - #17
Merged
Merged
Conversation
The framework removed z2ui5_cl_ai_xml (abap2UI5/abap2UI5#2586); the view builder is z2ui5_cl_ui5_view_builder. The verbs map 1:1 - open/leaf/shut become ele/tag/end, a( ) and stringify( ) keep their names, and the attribute target rule is the same - so the rendered views come out identical. What could not be a plain rename: - z2ui5_cl_cci=>leaf becomes z2ui5_cl_cci=>tag, named after the builder verb it mirrors. The new builder takes no attribute table, so the method now owns the ty_t_attr type and sets each surviving key=value pair through its own a( ) call. - as_bool( ) is gone; a boolean from an ABAP variable goes through a( )'s b parameter (sample_01), and the two builder docs that recommended as_bool( ) now name the true/false literals instead. Touching every sample also deletes the 21 client->view_model_update( ) calls - the method is obsolete and does nothing, the framework pushes a changed model on its own - and reworks the three prose mentions (sample_04, sample_10, README, ChartJs.js with regenerated BSP). abaplint green against the framework's main; abap2UI5-linter reconstructs and renders all 11 sample views, the obsolete-model-update findings are gone, the remaining findings predate this change. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011MiigXtbxL5Z4prr5QK23C
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The framework removed z2ui5_cl_ai_xml (abap2UI5/abap2UI5#2586); the view builder is z2ui5_cl_ui5_view_builder. The verbs map 1:1 - open/leaf/shut become ele/tag/end, a( ) and stringify( ) keep their names, and the attribute target rule is the same - so the rendered views come out identical.
What could not be a plain rename:
Touching every sample also deletes the 21 client->view_model_update( ) calls - the method is obsolete and does nothing, the framework pushes a changed model on its own - and reworks the three prose mentions (sample_04, sample_10, README, ChartJs.js with regenerated BSP).
abaplint green against the framework's main; abap2UI5-linter reconstructs and renders all 11 sample views, the obsolete-model-update findings are gone, the remaining findings predate this change.
Claude-Session: https://claude.ai/code/session_011MiigXtbxL5Z4prr5QK23C