Rename CDS framework classes to RAP namespace - #6
Merged
Merged
Conversation
Adopt the samples repo naming scheme (Z2UI5_CL_SMP_…, Z2UI5_T_SMP_…) with `RAP` as this addon's token, so every object carries Z2UI5_<type>_RAP_: - 8 classes: z2ui5_cl_cds_* -> z2ui5_cl_rap_* - 2 DDLS: z2ui5_cds_* -> z2ui5_dd_rap_* All references updated in the ABAP sources, the abapGit sidecars (CLSNAME, DDLNAME), the `define abstract entity` headers, README and AGENTS.md. The `cds_view_name` constructor parameter and the CDS wording in object descriptions are part of the public contract / prose and stay unchanged. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WrKoVnVksBAL6G5QJmTXfk
There was a problem hiding this comment.
Pull request overview
Refactors the addon’s ABAP CDS wrapper artifacts to use the Z2UI5_CL_RAP_ / Z2UI5_DD_RAP_ object naming scheme (classes + DDLS) and updates in-repo references/documentation accordingly, aligning with the project’s RAP-prefixed artifact convention.
Changes:
- Renamed CDS wrapper classes from
Z2UI5_CL_CDS_*toZ2UI5_CL_RAP_*and updated all type references/casts/instantiations to the new class names. - Renamed DDLS entities from
Z2UI5_CDS_*toZ2UI5_DD_RAP_*(XMLDDLNAME+ CDS source entity name) and updated ABAP type usages. - Updated
README.mdandAGENTS.mdexamples/references to the new artifact names.
Reviewed changes
Copilot reviewed 22 out of 24 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/z2ui5_dd_rap_test_popup.ddls.xml | Updates DDLNAME to the new Z2UI5_DD_RAP_* artifact name. |
| src/z2ui5_dd_rap_test_popup.ddls.baseinfo | Adds a .baseinfo artifact file (currently empty). |
| src/z2ui5_dd_rap_test_popup.ddls.asddls | Renames the CDS abstract entity to z2ui5_dd_rap_test_popup. |
| src/z2ui5_dd_rap_test_op.ddls.xml | Updates DDLNAME to the new Z2UI5_DD_RAP_* artifact name. |
| src/z2ui5_dd_rap_test_op.ddls.baseinfo | Adds a .baseinfo artifact file (currently empty). |
| src/z2ui5_dd_rap_test_op.ddls.asddls | Renames the CDS abstract entity to z2ui5_dd_rap_test_op. |
| src/z2ui5_cl_rap_worklist.clas.xml | Updates class metadata to Z2UI5_CL_RAP_WORKLIST. |
| src/z2ui5_cl_rap_worklist.clas.abap | Renames class and updates util type references/calls. |
| src/z2ui5_cl_rap_value_help.clas.xml | Updates class metadata to Z2UI5_CL_RAP_VALUE_HELP. |
| src/z2ui5_cl_rap_value_help.clas.abap | Renames class and updates util type references/calls. |
| src/z2ui5_cl_rap_util.clas.xml | Updates class metadata to Z2UI5_CL_RAP_UTIL. |
| src/z2ui5_cl_rap_util.clas.abap | Renames class definition/implementation. |
| src/z2ui5_cl_rap_test.clas.xml | Updates class metadata to Z2UI5_CL_RAP_TEST. |
| src/z2ui5_cl_rap_test.clas.abap | Renames demo app class and updates referenced RAP class/entity types. |
| src/z2ui5_cl_rap_overview_page.clas.xml | Updates class metadata to Z2UI5_CL_RAP_OVERVIEW_PAGE. |
| src/z2ui5_cl_rap_overview_page.clas.abap | Renames class and updates util type references/calls. |
| src/z2ui5_cl_rap_object_page.clas.xml | Updates class metadata to Z2UI5_CL_RAP_OBJECT_PAGE. |
| src/z2ui5_cl_rap_object_page.clas.abap | Renames class and updates util type references/calls. |
| src/z2ui5_cl_rap_list_report.clas.xml | Updates class metadata to Z2UI5_CL_RAP_LIST_REPORT. |
| src/z2ui5_cl_rap_list_report.clas.abap | Renames class and updates util type references/calls and navigation casts. |
| src/z2ui5_cl_rap_action_dialog.clas.xml | Updates class metadata to Z2UI5_CL_RAP_ACTION_DIALOG. |
| src/z2ui5_cl_rap_action_dialog.clas.abap | Renames class and updates util type references/calls. |
| README.md | Updates examples/references to new RAP-prefixed artifacts. |
| AGENTS.md | Updates demo class name and documents the RAP artifact naming scheme. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rename all CDS framework classes and data definitions from the
Z2UI5_CL_CDS_/Z2UI5_CDS_namespace to theZ2UI5_CL_RAP_/Z2UI5_DD_RAP_namespace to align with the naming convention used in the samples repository.Key Changes
Class renames (7 classes):
z2ui5_cl_cds_test→z2ui5_cl_rap_test(demo app)z2ui5_cl_cds_util→z2ui5_cl_rap_util(metadata reader)z2ui5_cl_cds_action_dialog→z2ui5_cl_rap_action_dialogz2ui5_cl_cds_list_report→z2ui5_cl_rap_list_reportz2ui5_cl_cds_object_page→z2ui5_cl_rap_object_pagez2ui5_cl_cds_overview_page→z2ui5_cl_rap_overview_pagez2ui5_cl_cds_worklist→z2ui5_cl_rap_worklistz2ui5_cl_cds_value_help→z2ui5_cl_rap_value_helpDDLS entity renames (2 entities):
z2ui5_cds_test_popup→z2ui5_dd_rap_test_popupz2ui5_cds_test_op→z2ui5_dd_rap_test_opUpdated all references throughout the codebase to use the new class and entity names
Documentation updates in README.md and AGENTS.md to reflect the new naming scheme and clarify that the
RAPprefix applies to object names only, not tocds_view_nameparameters or CDS terminology in descriptionsImplementation Details
Z2UI5_<type>_RAP_for classes andZ2UI5_DD_RAP_for DDLS entitieshttps://claude.ai/code/session_01WrKoVnVksBAL6G5QJmTXfk