Repository navigation
Release 0.3.1, and run the tests on MySQL in CI - #62
Merged
Merged
Conversation
CI ran Postgres and libSQL but not MySQL, so the MySQL driver went unchecked on every change. It passes the whole suite; this adds a MySQL 8.4 service so it stays that way. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
MySQL in CI. The workflow ran the suite on SQLite, Postgres and libSQL, but never MySQL, so that driver went unchecked on every change. This adds a MySQL 8.4 service and
TEST_MYSQL_URL. No code changes were needed: the suite already passes on MySQL.Version 0.3.1.
package.jsonandsrc/version.ts. After this merges and CI passes onmain, taggingv0.3.1runs the release workflow.What 0.3.1 contains (since v0.3.0)
sha256(rawNonce); the token's own nonce claim no longer passes (Close three security gaps and fix the libSQL paginate test #61).onebase upgradeverifies the release's signed build attestation;--no-verifyskips it (Close three security gaps and fix the libSQL paginate test #61).ONEBASE_SECRET_KEY, uploaded files in backups are encrypted, and earlier plain copies are replaced (Close three security gaps and fix the libSQL paginate test #61).ONEBASE_WATCHDOG, default 30s) (Stop a stuck server, and check documents for a deploy without holding writes #60).Testing
mysql:8.4in Docker with the same URL as the workflow: 722 pass, 3 skipped, 0 fail.🤖 Generated with Claude Code